This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyzer): noExtraSemicolons, noExtraSemi
#4061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
xunilrj
reviewed
Dec 16, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_extra_semicolons.rs
Outdated
Show resolved
Hide resolved
leops
reviewed
Dec 16, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_extra_semicolons.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_extra_semicolons.rs
Outdated
Show resolved
Hide resolved
added one check of list removed duplicated enums added code block for invalid and valid cases
…er-no-extra-semicolons
ematipico
approved these changes
Dec 19, 2022
|
Sorry, closed by accident! |
|
@ktfth you should rebase your PR and run |
leops
approved these changes
Dec 19, 2022
Doing right now, in a few minutes the process can be completed. Thank you for the adivice. |
|
@ematipico done with changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lint rule to check for extra semicolons, suggesting remove each occurrence
Closes 3988 part of recommended rules
Test Plan
Based on eslint instruction on the issue 3988, we covered some cases described as frequent in this case of scenario and
support existing rules before
noExtraSemicolonsappear.Documentation
Included on the common way of rome offer, splitting each case as documentation.