This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_json_formatter): JSON Formatting object #2570 #4040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
denbezrukov
commented
Dec 12, 2022
|
|
||
| #[derive(Debug, Clone, Default)] | ||
| pub(crate) struct FormatJsonMember; | ||
|
|
||
| impl FormatNodeRule<JsonMember> for FormatJsonMember { | ||
| fn fmt_fields(&self, node: &JsonMember, f: &mut JsonFormatter) -> FormatResult<()> { | ||
| format_verbatim_node(node.syntax()).fmt(f) | ||
| let content = format_with(move |f| { |
There was a problem hiding this comment.
Prettier uses for json only one layout type:
MichaReiser
approved these changes
Dec 12, 2022
MichaReiser
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2570 for Object value.
Open questions:
How can we reuse
separatedbetween json and js crate?Test Plan
cargo test -p rome_json_formatter