This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyzer): rule useAriaProps
#4048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
4dcf708 to
796f74d
Compare
xunilrj
reviewed
Dec 13, 2022
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_props.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 13, 2022
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_props.rs
Outdated
Show resolved
Hide resolved
5b334b8 to
61ae0fa
Compare
leops
reviewed
Dec 15, 2022
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_props.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_props.rs
Outdated
Show resolved
Hide resolved
61ae0fa to
70ff8e1
Compare
70ff8e1 to
6b8b4b8
Compare
|
@leops Can I get a review here, please? |
leops
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
I think the only minor issue I could see is the name of the rule, it might be more appropriate to call it useValidAriaProps / noInvalidAriaProps in order to clearly explain that the rule is only doing validation, it does not enforce that ARIA attributes are present
6b8b4b8 to
c85f545
Compare
c85f545 to
a91d13e
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3887
Test Plan
New test cases added.