This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyzer): add noWith rule
#4025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as part of the linter rules checker an analyzer was added checking for basic bahavior with a with statement as mentioned on the eslint reference
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
content formatted for no with statements
one case for test on no with statements
renamed all entities involved on the no with rule added test case improve message diagnosis checked all the requirements before submit changes
removed codegen for aria because of a failure on check
added resource to support no with statements rule
noWith rule
ematipico
suggested changes
Dec 12, 2022
added additional information to contextualize the rule removed unusued code and information
ematipico
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3993
This PR implements the following:
Added an rule with instructions to follow based on eslint definition to not use with statements
Test Plan
I created an invalid case with the code to be matched by the analyzer and has no need for a valid case