+
Skip to content

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Jan 18, 2024

Close #3105

@retlehs retlehs requested a review from knowler January 18, 2024 19:07
@retlehs retlehs self-assigned this Jan 18, 2024
@github-actions github-actions bot added views php Pull requests that update PHP code labels Jan 18, 2024
Copy link
Member

@knowler knowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some related code changes. You can drop the word “navigation” since screen readers will already announce that after the label (otherwise it’ll say “Page navigation navigation”).

retlehs and others added 3 commits January 18, 2024 13:16
Co-authored-by: Nathan Knowler <nathan@knowler.me>
Co-authored-by: Nathan Knowler <nathan@knowler.me>
Co-authored-by: Nathan Knowler <nathan@knowler.me>
@retlehs retlehs requested a review from knowler January 18, 2024 19:16
@retlehs retlehs merged commit 0365fb2 into main Jan 18, 2024
@retlehs retlehs deleted the nav-accessibility branch January 18, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

php Pull requests that update PHP code views

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: additional <nav> elements in partials need accessible names

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载