Remove defunct dead-code associated SystemTap artifacts #2965 #2966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the subject binary artifacts to avoiding possible confusion. All existing SystemTap SProbe code (dead) remains to server as a guide; assuming this entire subsystem is not later superseded/deleted.
FroggyFlox
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Thanks a lot for digging into that and clearly laying it out.
I completely agree that this should be cleaned up to help with our overall code base simplification and removing unnecessary binary blobs.
Hopefully we'll be able to implement a nice and modern alternative at some point in the future.
Test - just in caseTested basic NFS function: just in case. Rockstor instance:
Client:OpenSUSE client so users group (100) shared with server (Rockstor) OS. Rockstor instance:File was confirmed to exist on Rockstor instance:
|
|
@FroggyFlox Thanks for the review, as always much appreciated. I've since done a basic NFS test: likely redundant but no harm done apparently :). Merging to move on with our current milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the subject binary artifacts to avoiding possible confusion. All existing SystemTap SProbe code (dead) remains to server as a guide; assuming this entire subsystem is not later superseded/deleted.
Fixes #2965