-
Notifications
You must be signed in to change notification settings - Fork 142
User Pincard generation fails #2958 #2959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Pincard generation fails #2958 #2959
Conversation
Move associated code from Python 2.7 to 3. Includes: - Adding typehints. - User facing text refinement through-out. - Reword/simplify Pincard Manager dialog. - Move code comments to DocStrings. - Use String.format. - Add pincard icon colour flag. Green exists, red indicates no pincard exists. - Pincard logging tweaks. - Add info log to all smbpasswd calls.
TestingAn rpm was build and installed on a Leap 15.6 host, x86_64 arch. Initial pincard indicatorsWeb-UI admin user created during setup: Non-Web-UI user created via Web-UI (managed user): Root user: Clicking on the above 'root' user Pincard icon resulted in the display of the System -> Email Alerts config setup page. |
Pincard displayWhen cliicking on the Pincard icon the following is presented, randomly generated with each creation/recreation. And a highlight cut-paste of the text only version results in, in this case:
|
Works a treat. thanks again @phillxnet! For some reason, Right-clicking and "Save Image as..." on my machine does not do anything... no response from the browser or error in the JS console. I'm not sure what's going on. It's something on my end, though, as I can still use the text version of take a screenshot and use that pincard to reset the password for a managed user just fine!
I created a new user
|
@FroggyFlox Thanks for taking a look at this PR, much appreciated.
OK, this worked for me also, addressing the referenced issue.
OK, that was the bit that failed for me: but only for managed non-web ui users. So we likely need to proper reproducer for the failure I saw. Great that it may have been at my end some how thought. Lets keep an eye out for reports of this particular failure to see if we can get to a reproducer. For now it may well have been some caching issue at my end perhaps. Strange you browser refused to enact the right-click save on the image version of the pincard. Again we should keep an eye out for this in reports to get more info. But as stated there is the text option and screen pic approach. I'll try to include that in the accompanying doc section; when time allows. I'll take this as a functional review: which is all we need really; given we had abject failure previously. I was keen to avoid that with any key feature prior to our pending stable release. I'll merge shortly so we can get this fix in the next release. |
Move associated code from Python 2.7 to 3.
Fixes #2958
Includes:
Caveat: on final testing we have working
root
user and initial setup-created/webui admin user password reset.But there remains a bug in non-webui managed user reset where-by no response is given after valid codes are entered. It is proposed that this be addressed at a later date under another issue as this is a less common scenario and does not pertain to the original issue addressed here: in that a pincode is successfully generated and presented for a non-webui-user during tests against this branch: see #2959 (comment) below.