Inactive NFS export validation #2924 #2926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable intended NFS model field validations during POST & PUT by calling NFSExportGroup.clean_fields() prior to model.save(). N.B. There exists a build-in `choices=` field validator that takes precedence for the fields: 'editable', and 'syncable'. So only the 'host_str' field actively exercises the custom validators. I.e. we have redundant validators for 'editable', and 'syncable'. This redundancy is not the focus of this fix: only re-enabling model field validation. ## Includes - Above fix regarding model field validation. - Incidental fix for newer Django warning surfaced by recent NFS test updates: "Pagination may yield inconsistent results with an unordered object_list ...". Adds a default ordering on `id` in NFSExportGroup model. - Remove outdated model comment regarding editable default: NFSExportGroup model - nfs_export_group.py model definition file black re-formatted.
TestingBeforeSee the associated issue #2924 (comment) for details of the existing test failures: detailing model field validation failure. AfterOn a Leap 15.6 host (x86_64) via rpm (built on host) install from this PR branch (5.0.14-2926): Pertinent test setAll tests(A prerequisite of a successful rpmbuild) As per doc instructions: https://rockstor.com/docs/contribute/contribute.html#code-test |
Web-UI back-end validation feedbackAs per referenced issue #2924 reproducer re allowed "1.!" host_str, using the same input thus: Results in our Web-UI user error feedback dialog: Indicating our successfully surfacing this newly enabled model field validation. Also, no export was entered into the DB (no model.save() ), and no export was created on the underlying NFS config (/etc/exports). |
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable intended NFS model field validations during POST & PUT by calling NFSExportGroup.clean_fields() prior to model.save().
N.B. There exists a build-in
choices=field validator that takes precedence for the fields: 'editable', and 'syncable'. So only the 'host_str' field actively exercises the custom validators. I.e. we have redundant validators for 'editable', and 'syncable'. This redundancy is not the focus of this fix: only re-enabling model field validation.Fixes #2924
Includes
idin NFSExportGroup model.