+
Skip to content

Support backslash in getSlug util #6691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-snails-study.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@reactioncommerce/api-utils": patch
---

Support `/` in the getSlug utility function
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# See comment in docker-compose.dev.yml if you want to run for development.

version: "3.4"
version: "3.9"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this PR include a change to the docker file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax we use for the network declaration in the docker compose file is not supported in 3.4

networks:
  reaction:
    name: reaction.localhost
    external: true

I had errors in the IDE so I decided to bump it. This does not bring breaking behavior from what I've observed. I had all my docker-compose files to version 3.9 locally for months and haven't encountered any problems.


networks:
reaction:
Expand Down
2 changes: 1 addition & 1 deletion packages/api-utils/lib/getSlug.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ const { slugify } = require("transliteration");
* @returns {String} slugified string
*/
export default function getSlug(slugString) {
return (typeof slugString === "string" && slugify(slugString)) || "";
return (typeof slugString === "string" && slugify(slugString, { allowedChars: "a-zA-Z0-9-/" })) || "";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tedraykov

Actually coming back to this I am concerned about this change being a global one and not specific to tags and may result in some unexpected behavior. I wonder if we can add a second argument of allowedChars, so that the default behavior remains the same.

}
13 changes: 13 additions & 0 deletions packages/api-utils/lib/getSlug.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import getSlug from "./getSlug.js";

it("should slugify a latin text", () => {
const text = "This is a title";
const slugified = getSlug(text);
expect(slugified).toEqual("this-is-a-title");
});

it("should slugify a latin text with / (backslash)", () => {
const text = "men/jacket";
const slugified = getSlug(text);
expect(slugified).toEqual("men/jacket");
});
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载