+
Skip to content

feat: upgrade mongodb to 4.4 #6588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 19, 2022
Merged

feat: upgrade mongodb to 4.4 #6588

merged 8 commits into from
Dec 19, 2022

Conversation

vanpho93
Copy link
Member

Signed-off-by: Brian Nguyen vanpho02@gmail.com

Resolves #6383
Type: feature

Issue

MongoDB 4.2 will reach EOD soon. We should update to MongoDB 5.

Solution

Bump mongodb driver version from v3.6.2 to v4.4.1.
Modify collection object to support v3 queries

Breaking changes

https://github.com/mongodb/node-mongodb-native/blob/4.1/docs/CHANGES_4.0.0.md

Some changes resolved by this PR:

returnOriginal
{ result: { ok: 1, n: 1 } }

Testing

Run e2e test.

More detail for what each of these sections should include are available in our Contributing Docs

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

🦋 Changeset detected

Latest commit: 189a6f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@reactioncommerce/api-core Minor
@reactioncommerce/file-collections-sa-gridfs Minor
reaction Patch
@reactioncommerce/api-plugin-files Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brent-hoover
Copy link
Collaborator

Should this be a minor change rather than patch? It's not a bug fix

@brent-hoover brent-hoover requested a review from aldeed December 1, 2022 08:09
aldeed
aldeed previously approved these changes Dec 8, 2022
Copy link
Contributor

@aldeed aldeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but LGTM

@vanpho93 vanpho93 force-pushed the feat/upgrade-mongodb branch 2 times, most recently from bf09c36 to 9ba2c7d Compare December 14, 2022 02:21
brent-hoover
brent-hoover previously approved these changes Dec 19, 2022
Signed-off-by: vanpho93 <vanpho02@gmail.com>
Signed-off-by: vanpho93 <vanpho02@gmail.com>
Signed-off-by: Brian Nguyen <vanpho02@gmail.com>
Signed-off-by: vanpho93 <vanpho02@gmail.com>
Signed-off-by: Brian Nguyen <vanpho02@gmail.com>
Signed-off-by: vanpho93 <vanpho02@gmail.com>
Signed-off-by: vanpho93 <vanpho02@gmail.com>
Signed-off-by: vanpho93 <vanpho02@gmail.com>
Signed-off-by: vanpho93 <vanpho02@gmail.com>
@brent-hoover brent-hoover self-requested a review December 19, 2022 11:09
@brent-hoover brent-hoover merged commit 61424f1 into trunk Dec 19, 2022
@brent-hoover brent-hoover deleted the feat/upgrade-mongodb branch December 19, 2022 11:09
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to MongoDB 5
3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载