fix: update surcharge mutation will send the whole item #6569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 135c54e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@delagroove Please review the changes, Thanks! |
|
Hi @sushmitha-malae, can you sign-off your commits? |
|
@sushmitha-malae You have failing tests here |
…lae/reaction into fix-updateSurcharge
This reverts commit 9d6b5a6.
Signed-off-by: Sushmitha Malae <malaesushmitha@gmail.com> Signed-off-by: m_sushmitha <m_sushmitha@intuit.com>
|
having some problem with the sign off on the commits, raised duplicate PR. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sushmitha Malae malaesushmitha@gmail.com
Resolves #6508
Impact: minor
Type: bugfix
Issue
The updateSurcharge Mutation will only return the updated fields instead of returning the full item from db
Solution
Returning the updated full document instead of the partially updated fields.
Breaking changes
None
Testing
Modified the existing utc, to test the change.
More detail for what each of these sections should include are available in our Contributing Docs. This project uses semantic-release, please use their commit message format..