Project invitation: confirmation dialog #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vico-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ajolipa
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
This PR adds a confirmation popup after the user accepts a project invitiation. Beta testers had real trouble understanding what was going on when they clicked "accept". The UI didn't change for them. Unless they happened to be in the "Shared with Me" view, there was no visual feedback at all for them.
This PR adds a popup, which confirms that the action to join the project was indeed successful, and explains where to find the project in the Dashboard.
This PR complements other measures to improve UX, namely the addition of counter badges for the Dashboard tabs and the All Projects tab as the default dashboard view.