feat: install and report actions #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmayajush
commented
Aug 10, 2023
- added seperate actions for install and report.
rajaSahil
requested changes
Aug 11, 2023
actions/install-action/action.yaml
Outdated
Comment on lines
16
to
19
| outputs: | ||
| random-number: | ||
| description: "Random number" | ||
| value: ${{ steps.random-number-generator.outputs.random-number }} |
actions/report-action/action.yaml
Outdated
| baseline-report-path: | ||
| description: 'baseline report path' | ||
| required: true | ||
| default: "baseline/report.json > downloads/table" |
There was a problem hiding this comment.
Suggested change
| default: "baseline/report.json > downloads/table" | |
| default: "baseline/report.json" |
actions/report-action/action.yaml
Outdated
Comment on lines
8
to
42
| labels: | ||
| description: 'labels' | ||
| required: false | ||
| operation: | ||
| description: 'operation' | ||
| required: false | ||
| container-name: | ||
| description: 'container name' | ||
| required: false | ||
| namespaces: | ||
| description: 'namespaces' | ||
| required: false | ||
| workloads: | ||
| description: 'workloads' | ||
| required: false | ||
| source: | ||
| description: 'source' | ||
| required: false | ||
| process-ignore-paths: | ||
| description: 'process ignore paths' | ||
| required: false | ||
| default: '/sbin' | ||
| file-ignore-paths: | ||
| description: 'file ignore paths' | ||
| required: false | ||
| default: '/sbin' | ||
| ignore-return-code: | ||
| description: 'ignore return code. possible values: true/false' | ||
| required: false |
There was a problem hiding this comment.
Make default value as empty string.
actions/report-action/action.yaml
Outdated
Comment on lines
37
to
40
| view: | ||
| description: 'view' | ||
| required: false | ||
| default: 'tabular/' |
There was a problem hiding this comment.
Suggested change
| view: | |
| description: 'view' | |
| required: false | |
| default: 'tabular/' | |
| view: | |
| description: 'view' | |
| required: false | |
| default: 'tabular' |
actions/report-action/action.yaml
Outdated
Comment on lines
42
to
45
| outputs: | ||
| random-number: | ||
| description: "Random number" | ||
| value: ${{ steps.random-number-generator.outputs.random-number }} |
There was a problem hiding this comment.
This is not required for phase 1
actions/report-action/action.yaml
Outdated
Comment on lines
52
to
54
| kubectl get pods -A | ||
| sleep 200 | ||
| kubectl get pods -A |
actions/report-action/action.yaml
Outdated
Comment on lines
83
to
86
| ./accuknox-cli report $setupArgs | ||
|
|
||
| cat downloads/table | ||
| mv /tmp/report-*.json downloads/report.json | ||
| mv /tmp/diff-report-*.json downloads/diff-report.json | ||
| mv /tmp/diff-report-*.md downloads/diff-report.md |
There was a problem hiding this comment.
Suggested change
| ./accuknox-cli report $setupArgs | |
| cat downloads/table | |
| mv /tmp/report-*.json downloads/report.json | |
| mv /tmp/diff-report-*.json downloads/diff-report.json | |
| mv /tmp/diff-report-*.md downloads/diff-report.md | |
| ./accuknox-cli report $setupArgs | |
| mkdir downloads | |
| mv /tmp/report-*.json downloads/report.json | |
| mv /tmp/diff-report-*.json downloads/diff-report.json | |
| mv /tmp/diff-report-*.md downloads/diff-report.md |
rajaSahil
reviewed
Aug 14, 2023
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: Baseline report | ||
| path: downloads |
There was a problem hiding this comment.
Also add this as a next step for this action
- name: PR comment with file
uses: thollander/actions-comment-pull-request@v2
with:
filePath: downloads/diff-report.md
update added flags and args fixes added branding fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.