added 'q' to quit prompt #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,10 +20,10 @@ if (opts.indexOf('-h') > -1) { | |||
| gitBc.on('success', log.success); | |||
|
|
|||
| // Exits program execution on ESC keypress | |||
| process.stdin.on('keypress', function (ch, key) { | |||
| if (key && key.name === 'escape') { | |||
| process.stdin.on('keypress', function(ch, key) { | |||
There was a problem hiding this comment.
oh, this line got changed for no reason at all 😞 plus it breaks my standard of always having a space between function declaration and parenthesis :)
other than that LGTM 👍
There was a problem hiding this comment.
Yeah, my bad for the space, also I was looking for autocomplete and thought if was more readable if we added multiples functions like autocomplete searches after to just separate on 2 lines the key verification but as this commit is only to add the Q key, i removed them 👍
7e37122 to
67f2d46
Compare
| process.exit(); | ||
| } | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
|
🎊 many thanks @zeachco 😃 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe having "q" to exit feel more intuitive being in git prompt?