Do not use mutable value for defaults #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default values are generated only one, and using a mutable value as a default causes unintentional shared value updated by different method calls.
8ebc1c1 to
2e05dc4
Compare
| @@ -221,7 +221,7 @@ class PecanBase(object): | |||
|
|
|||
| def __init__(self, root, default_renderer='mako', | |||
| template_path='templates', hooks=lambda: [], | |||
| custom_renderers={}, extra_template_vars={}, | |||
There was a problem hiding this comment.
These aren't assigned defaults.
Also, pecan.templating.RendererFactory has the same problem in its constructor.
There was a problem hiding this comment.
RendererFactory translates custom_renderers=None to {}, and also extra_vars=None is translated to {} by ExtraNamespace , which is called by RendererFactory.
I can add the logic to translate None in every layer but I avoided it because it is technically redundant.
There was a problem hiding this comment.
Ah, I see. Yep, that makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default values are generated only one, and using a mutable value as a default causes unintentional shared value updated by different method calls.