Remove compatibility code for old python and webob #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum version of WebOb has been 1.8.0 for some time.
functools.singledispatch was added in Python 3.4. [1] https://docs.python.org/3.13/library/functools.html#functools.singledispatch
Now the minimum supported is 3.8 .
... because Python 3.5 is no longer supported.
... because the pep8 package was renamed to pycodestyle long ago after its 1.7.0 release. Also fix the failures detected by pycodestyle.
|
I also noticed the UserWarning caused by pep8 still used so I included the change to replace it in this PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop code for Python < 3 because the minimum supported version is now Python 3.8 .
In addition, the minimum version of WebOb has been 1.8.0, so any code for older WebOb can be dropped, too.