Type RaisesGroup properly
#3141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(I cannot test this locally because our Sphinx builds fail on Windows)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3141 +/- ##
==========================================
- Coverage 99.62% 94.05% -5.57%
==========================================
Files 122 122
Lines 18400 18400
Branches 1223 1222 -1
==========================================
- Hits 18331 17307 -1024
- Misses 47 1010 +963
- Partials 22 83 +61
|
jakkdl
requested changes
Nov 19, 2024
Co-authored-by: John Litborn <11260241+jakkdl@users.noreply.github.com>
CoolCat467
approved these changes
Nov 25, 2024
jakkdl
reviewed
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jakkdl because you wrote this / these comments
This should fix the typing weirdness around it. I didn't really look too hard at things originally so there might be some outdated comments.
Maybe also @TeamSpen210 because types
... also this might be easier to review commit by commit. I tried my best to keep things separated (eg staging hunks so that only related pieces were in a single commit). However, I did not run mypy / tests after every single commit so things may be broken after a commit.