Enable LineariseRewards to work with negative weights
#3064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3064
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Pending, 5 Unrelated FailuresAs of commit 88ceb99 with merge base 523ba2e ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
louisfaury
reviewed
Jul 14, 2025
| def test_weight_sign_error(self): | ||
| with pytest.raises(ValueError, match="Expected all weights to be >0"): | ||
| LineariseRewards(in_keys=("reward",), weights=-torch.ones(size=(2,))) | ||
| def test_weight_no_sign_error(self): |
There was a problem hiding this comment.
Nit: its probably cleaner to remove this test now – it does not really test anything.
There was a problem hiding this comment.
Yeah I allowed it as a non regression test but you could have said that of the previous one 😄
vmoens
pushed a commit
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable
LineariseRewardsto work with negative weights.Motivation and Context
Fixes #3063.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!