[BugFix] Fix behavior or partial, nested dones in PEnv and TEnv #2959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2959
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 6 Pending, 2 Unrelated FailuresAs of commit 9185c7a with merge base 36f34da ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Comment on lines
2964
to
2991
| if done_at_root: | ||
| assert parallel_env._simple_done | ||
| assert transformed_env._simple_done | ||
| # We expect each env to have reached a done state once. | ||
| assert parallel_td["next", "done"].sum().item() == 2 | ||
| # We expect env[0] to have been reset and executed 2 steps. | ||
| # We expect env[1] to have just been reset (0 steps). | ||
| assert parallel_env._counter() == [2, 0] | ||
| assert parallel_td["next", "done"].sum().item() == 2 | ||
|
|
||
| # We expect each env to have reached a done state once. | ||
| assert transformed_td["next", "done"].sum().item() == 2 | ||
| assert_allclose_td(transformed_td, parallel_td, intersection=True) | ||
| # We expect env[0] to have been reset and executed 2 steps. | ||
| # We expect env[1] to have just been reset (0 steps). | ||
| # We only expect env[0] to have reached a done state. | ||
| else: | ||
| assert not parallel_env._simple_done | ||
| assert not transformed_env._simple_done | ||
| assert ("next", "done") not in parallel_td | ||
| assert ("next", "done") not in transformed_td | ||
| assert parallel_td["next", "agent_1", "done"].sum().item() == 2 | ||
| assert parallel_env._counter() == [2, 0] | ||
| assert parallel_td["next", "agent_1", "done"].sum().item() == 2 | ||
| assert transformed_td["next", "agent_1", "done"].sum().item() == 2 | ||
| assert_allclose_td(transformed_td, parallel_td, intersection=True) | ||
|
|
||
| assert transformed_env._counter() == [2, 0] |
There was a problem hiding this comment.
I think there's a mismatch in the asserts and comments and some asserts are duplicated. Maybe this helps:
Suggested change
| if done_at_root: | |
| assert parallel_env._simple_done | |
| assert transformed_env._simple_done | |
| # We expect each env to have reached a done state once. | |
| assert parallel_td["next", "done"].sum().item() == 2 | |
| # We expect env[0] to have been reset and executed 2 steps. | |
| # We expect env[1] to have just been reset (0 steps). | |
| assert parallel_env._counter() == [2, 0] | |
| assert parallel_td["next", "done"].sum().item() == 2 | |
| # We expect each env to have reached a done state once. | |
| assert transformed_td["next", "done"].sum().item() == 2 | |
| assert_allclose_td(transformed_td, parallel_td, intersection=True) | |
| # We expect env[0] to have been reset and executed 2 steps. | |
| # We expect env[1] to have just been reset (0 steps). | |
| # We only expect env[0] to have reached a done state. | |
| else: | |
| assert not parallel_env._simple_done | |
| assert not transformed_env._simple_done | |
| assert ("next", "done") not in parallel_td | |
| assert ("next", "done") not in transformed_td | |
| assert parallel_td["next", "agent_1", "done"].sum().item() == 2 | |
| assert parallel_env._counter() == [2, 0] | |
| assert parallel_td["next", "agent_1", "done"].sum().item() == 2 | |
| assert transformed_td["next", "agent_1", "done"].sum().item() == 2 | |
| assert_allclose_td(transformed_td, parallel_td, intersection=True) | |
| assert transformed_env._counter() == [2, 0] | |
| # We expect env[0] to have been reset and executed 2 steps. | |
| # We expect env[1] to have just been reset (0 steps). | |
| assert parallel_env._counter() == [2, 0] | |
| assert transformed_env._counter() == [2, 0] | |
| if done_at_root: | |
| assert parallel_env._simple_done | |
| assert transformed_env._simple_done | |
| # We expect each env to have reached a done state once. | |
| assert parallel_td["next", "done"].sum().item() == 2 | |
| assert transformed_td["next", "done"].sum().item() == 2 | |
| assert_allclose_td(transformed_td, parallel_td, intersection=True) | |
| else: | |
| assert not parallel_env._simple_done | |
| assert not transformed_env._simple_done | |
| assert ("next", "done") not in parallel_td | |
| assert ("next", "done") not in transformed_td | |
| assert parallel_td["next", "agent_1", "done"].sum().item() == 2 | |
| assert transformed_td["next", "agent_1", "done"].sum().item() == 2 | |
| assert_allclose_td(transformed_td, parallel_td, intersection=True) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):