+
Skip to content

[Refactor] VecNormV2: update before norm, bias_correction at the right time #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2025
Merged

[Refactor] VecNormV2: update before norm, bias_correction at the right time #2900

merged 4 commits into from
Apr 11, 2025

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented Apr 10, 2025 •
edited
Loading

Update
276324c 
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Apr 10, 2025
[Refactor] VecNormV2: update before norm, bias_correction at the righ…
7a5efb6 
…t time

ghstack-source-id: 4513567
Pull Request resolved: #2900
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2900

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2025
Update
7434396 
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Apr 10, 2025
[Refactor] VecNormV2: update before norm, bias_correction at the righ…
b3b70c1 
…t time

ghstack-source-id: 3d120c6
Pull Request resolved: #2900
Update
36d21ff 
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Apr 10, 2025
[Refactor] VecNormV2: update before norm, bias_correction at the righ…
abe1f91 
…t time

ghstack-source-id: 04eea72
Pull Request resolved: #2900
elin-bdai
elin-bdai approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@elin-bdai elin-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me. Thank you!

@vmoens vmoens added the Refactoring Refactoring of an existing feature label Apr 11, 2025
Update
be01d16 
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Apr 11, 2025
[Refactor] VecNormV2: update before norm, bias_correction at the righ…
b806fa1 
…t time

ghstack-source-id: a90aeb2
Pull Request resolved: #2900
@vmoens vmoens merged commit be01d16 into gh/vmoens/126/base Apr 11, 2025
36 of 55 checks passed
vmoens pushed a commit that referenced this pull request Apr 11, 2025
[Refactor] VecNormV2: update before norm, bias_correction at the righ…
c3310b8 
…t time

ghstack-source-id: a90aeb2
Pull Request resolved: #2900
@vmoens vmoens deleted the gh/vmoens/126/head branch April 11, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elin-bdai elin-bdai elin-bdai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmoens @elin-bdai @facebook-github-bot
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载