+
Skip to content

Conversation

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2859

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2025
vmoens pushed a commit that referenced this pull request Mar 18, 2025
ghstack-source-id: 369e690
Pull Request resolved: #2859
@vmoens vmoens added the bug Something isn't working label Mar 18, 2025
@vmoens vmoens linked an issue Mar 18, 2025 that may be closed by this pull request
3 tasks
@vmoens
Copy link
Collaborator Author

vmoens commented Mar 18, 2025

In this PR, I add an example to show how to sync weights when the native weight update class doesn't work (eg serializing mps weights is not possible so you can cast them to cpu then recast to mps)
I also fix the collectors and test the solution.
This should also make other update methods easier to implement.

cc @mikaylagawarecki

[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Mar 18, 2025
ghstack-source-id: 166cdfe
Pull Request resolved: #2859
@vmoens
Copy link
Collaborator Author

vmoens commented Mar 18, 2025

We also need to find a way to pass the local update to the sub-collector. With the distributed ones it's easy to do (we can pass any kwarg). For mp ones not so much atm

[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Mar 19, 2025
ghstack-source-id: 3101c9e
Pull Request resolved: #2859
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Mar 19, 2025
ghstack-source-id: b951eb0
Pull Request resolved: #2859
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Mar 19, 2025
ghstack-source-id: 6396c59
Pull Request resolved: #2859
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Mar 19, 2025
ghstack-source-id: 993ec0d
Pull Request resolved: #2859
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Mar 19, 2025
ghstack-source-id: 3af3a99
Pull Request resolved: #2859
[ghstack-poisoned]
Vincent Moens added 3 commits March 19, 2025 17:05
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Mar 20, 2025
ghstack-source-id: f938148
Pull Request resolved: #2859
Vincent Moens added 2 commits March 20, 2025 07:30
[ghstack-poisoned]
[ghstack-poisoned]
@vmoens vmoens merged commit cf9400a into gh/vmoens/121/base Mar 20, 2025
25 of 50 checks passed
vmoens pushed a commit that referenced this pull request Mar 20, 2025
ghstack-source-id: bce8abe
Pull Request resolved: #2859
@vmoens vmoens deleted the gh/vmoens/121/head branch March 20, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] DataCollectors fail when device is set to MPS

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载