-
Notifications
You must be signed in to change notification settings - Fork 413
[Feature] pass policy-factory in mp data collectors #2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2859
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
In this PR, I add an example to show how to sync weights when the native weight update class doesn't work (eg serializing mps weights is not possible so you can cast them to cpu then recast to mps) |
We also need to find a way to pass the local update to the sub-collector. With the distributed ones it's easy to do (we can pass any kwarg). For mp ones not so much atm |
Stack from ghstack (oldest at bottom):