Fixed VideoRecorder crash when passing fps #2827
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2827
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @AlexandreBrown! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
8a168a7 to
18d3c54
Compare
test/test_video_recorder.py
Outdated
There was a problem hiding this comment.
this should be moved to test/test_loggers.py
Description
Small fix to prevent a crash in VideoRecorder
Motivation and Context
Fixes #2826
When creating a VideoRecorder with the latest torchrl version, we get a crash if we pass
fpsargument sinceself.video_kwargsis not set yet we try to setself.video_kwargs['fps'] = fpsTypes of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!