+
Skip to content

Conversation

KubaMichalczyk
Copy link
Contributor

Close #2758

Copy link

pytorch-bot bot commented Feb 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2801

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens force-pushed the fix/resolve-dtype-dim branch from e344c26 to 5998c5e Compare February 21, 2025 14:13
@vmoens vmoens added the bug Something isn't working label Feb 21, 2025
@vmoens vmoens merged commit 21c4d87 into pytorch:main Feb 21, 2025
1 check passed
vmoens pushed a commit that referenced this pull request Mar 8, 2025
…2801)

Co-authored-by: Jakub Michalczyk <jakub.michalczyk@sportec-solutions.com>
(cherry picked from commit 21c4d87)
vmoens pushed a commit that referenced this pull request Mar 10, 2025
…2801)

Co-authored-by: Jakub Michalczyk <jakub.michalczyk@sportec-solutions.com>
(cherry picked from commit 21c4d87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] dtype in _split_and_pad_sequence is established using incorrect dim

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载