+
Skip to content

[BugFix] correct dim for resolving dtype in _split_and_pad_sequence #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

[BugFix] correct dim for resolving dtype in _split_and_pad_sequence #2801

merged 1 commit into from
Feb 21, 2025

Conversation

KubaMichalczyk
Copy link
Contributor

Close #2758

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2801

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
@KubaMichalczyk KubaMichalczyk mentioned this pull request Feb 21, 2025
Closed
vmoens
vmoens approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens force-pushed the fix/resolve-dtype-dim branch from e344c26 to 5998c5e Compare February 21, 2025 14:13
@vmoens vmoens added the bug Something isn't working label Feb 21, 2025
@vmoens vmoens merged commit 21c4d87 into pytorch:main Feb 21, 2025
1 check passed
vmoens pushed a commit that referenced this pull request Mar 8, 2025
@KubaMichalczyk
[BugFix] correct dim for resolving dtype in _split_and_pad_sequence (#…
276dee6 
…2801)

Co-authored-by: Jakub Michalczyk <jakub.michalczyk@sportec-solutions.com>
(cherry picked from commit 21c4d87)
vmoens pushed a commit that referenced this pull request Mar 10, 2025
@KubaMichalczyk
[BugFix] correct dim for resolving dtype in _split_and_pad_sequence (#…
c020b38 
…2801)

Co-authored-by: Jakub Michalczyk <jakub.michalczyk@sportec-solutions.com>
(cherry picked from commit 21c4d87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoens vmoens vmoens approved these changes

Assignees

No one assigned

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] dtype in _split_and_pad_sequence is established using incorrect dim

3 participants

@KubaMichalczyk @vmoens @facebook-github-bot
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载