+
Skip to content

[Feature] Make benchmarked losses compatible with torch.compile #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 17, 2024
Merged

[Feature] Make benchmarked losses compatible with torch.compile #2405

merged 13 commits into from
Sep 17, 2024

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented Aug 30, 2024 •
edited
Loading

Update
f6865af 
[ghstack-poisoned]
vmoens pushed a commit that referenced this pull request Aug 30, 2024
[Feature] Make benchmarked losses compatible with torch.compile
94d44e5 
ghstack-source-id: 699a6bb
Pull Request resolved: #2405
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2405

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 1 Cancelled Job, 10 Unrelated Failures

As of commit e4441a0 with merge base 605b4aa (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 30, 2024
Update
2548a64 
[ghstack-poisoned]
This was referenced Sep 2, 2024
Merged
Open
@vmoens vmoens added the enhancement New feature or request label Sep 2, 2024
Vincent Moens added 2 commits September 2, 2024 18:05
Update
e60bc17 
[ghstack-poisoned]
Update
ef7376b 
[ghstack-poisoned]
@vmoens
Copy link
Collaborator Author

vmoens commented Sep 3, 2024

Required merges before landing this:
pytorch/pytorch#135000 (comment)
pytorch/pytorch#135001

Update
09d2372 
[ghstack-poisoned]
@vmoens vmoens mentioned this pull request Sep 9, 2024
Open
Vincent Moens added 8 commits September 12, 2024 10:34
Update
c35f722 
[ghstack-poisoned]
Update
f9aa095 
[ghstack-poisoned]
Update
98e3914 
[ghstack-poisoned]
Update
ba42d13 
[ghstack-poisoned]
Update
56c93cb 
[ghstack-poisoned]
Update
771217c 
[ghstack-poisoned]
Update
0e30b4b 
[ghstack-poisoned]
Update
e4441a0 
[ghstack-poisoned]
@vmoens vmoens merged commit e4441a0 into gh/vmoens/20/base Sep 17, 2024
54 of 70 checks passed
vmoens pushed a commit that referenced this pull request Sep 17, 2024
[Feature] Make benchmarked losses compatible with torch.compile
2332909 
ghstack-source-id: 825ded5
Pull Request resolved: #2405
@vmoens vmoens deleted the gh/vmoens/20/head branch September 17, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens @facebook-github-bot
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载