+
Skip to content

Fix onw typo #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fix onw typo #1917

merged 2 commits into from
Feb 16, 2024

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Feb 16, 2024

No description provided.

@kit1980 kit1980 requested a review from vmoens February 16, 2024 05:13
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1917

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit a051f7c with merge base 67f659c (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 16, 2024
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 63.3327ms 61.3114ms 16.3102 Ops/s 16.1180 Ops/s $\color{#35bf28}+1.19\%$
test_sync 52.0785ms 36.1135ms 27.6905 Ops/s 29.4265 Ops/s $\textbf{\color{#d91a1a}-5.90\%}$
test_async 0.1272s 32.5320ms 30.7389 Ops/s 30.9031 Ops/s $\color{#d91a1a}-0.53\%$
test_simple 0.4961s 0.4374s 2.2862 Ops/s 2.2918 Ops/s $\color{#d91a1a}-0.24\%$
test_transformed 0.6290s 0.5802s 1.7235 Ops/s 1.6914 Ops/s $\color{#35bf28}+1.90\%$
test_serial 1.4516s 1.3974s 0.7156 Ops/s 0.6977 Ops/s $\color{#35bf28}+2.56\%$
test_parallel 1.4096s 1.3610s 0.7348 Ops/s 0.7146 Ops/s $\color{#35bf28}+2.82\%$
test_step_mdp_speed[True-True-True-True-True] 0.1149ms 21.0466μs 47.5135 KOps/s 46.7340 KOps/s $\color{#35bf28}+1.67\%$
test_step_mdp_speed[True-True-True-True-False] 56.2940μs 12.9020μs 77.5076 KOps/s 75.6262 KOps/s $\color{#35bf28}+2.49\%$
test_step_mdp_speed[True-True-True-False-True] 33.5520μs 12.3898μs 80.7117 KOps/s 79.1107 KOps/s $\color{#35bf28}+2.02\%$
test_step_mdp_speed[True-True-True-False-False] 51.9560μs 7.4505μs 134.2197 KOps/s 130.8366 KOps/s $\color{#35bf28}+2.59\%$
test_step_mdp_speed[True-True-False-True-True] 66.7040μs 22.5440μs 44.3578 KOps/s 43.3773 KOps/s $\color{#35bf28}+2.26\%$
test_step_mdp_speed[True-True-False-True-False] 48.1290μs 14.1774μs 70.5349 KOps/s 68.6753 KOps/s $\color{#35bf28}+2.71\%$
test_step_mdp_speed[True-True-False-False-True] 39.3930μs 13.6278μs 73.3796 KOps/s 71.5993 KOps/s $\color{#35bf28}+2.49\%$
test_step_mdp_speed[True-True-False-False-False] 43.9420μs 8.8305μs 113.2439 KOps/s 110.0557 KOps/s $\color{#35bf28}+2.90\%$
test_step_mdp_speed[True-False-True-True-True] 55.0830μs 24.0492μs 41.5813 KOps/s 41.0873 KOps/s $\color{#35bf28}+1.20\%$
test_step_mdp_speed[True-False-True-True-False] 38.9420μs 15.7230μs 63.6009 KOps/s 62.9844 KOps/s $\color{#35bf28}+0.98\%$
test_step_mdp_speed[True-False-True-False-True] 35.5260μs 13.7573μs 72.6885 KOps/s 71.4978 KOps/s $\color{#35bf28}+1.67\%$
test_step_mdp_speed[True-False-True-False-False] 54.6820μs 8.9075μs 112.2650 KOps/s 110.3087 KOps/s $\color{#35bf28}+1.77\%$
test_step_mdp_speed[True-False-False-True-True] 68.1660μs 25.1918μs 39.6954 KOps/s 39.7550 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[True-False-False-True-False] 47.7090μs 16.8284μs 59.4232 KOps/s 57.8381 KOps/s $\color{#35bf28}+2.74\%$
test_step_mdp_speed[True-False-False-False-True] 51.5490μs 14.8057μs 67.5416 KOps/s 65.5163 KOps/s $\color{#35bf28}+3.09\%$
test_step_mdp_speed[True-False-False-False-False] 34.8250μs 10.1452μs 98.5689 KOps/s 96.4730 KOps/s $\color{#35bf28}+2.17\%$
test_step_mdp_speed[False-True-True-True-True] 56.9660μs 23.9915μs 41.6815 KOps/s 41.2438 KOps/s $\color{#35bf28}+1.06\%$
test_step_mdp_speed[False-True-True-True-False] 36.7290μs 15.6102μs 64.0605 KOps/s 62.3478 KOps/s $\color{#35bf28}+2.75\%$
test_step_mdp_speed[False-True-True-False-True] 63.8390μs 15.9036μs 62.8789 KOps/s 60.6293 KOps/s $\color{#35bf28}+3.71\%$
test_step_mdp_speed[False-True-True-False-False] 38.5010μs 10.0376μs 99.6258 KOps/s 97.6530 KOps/s $\color{#35bf28}+2.02\%$
test_step_mdp_speed[False-True-False-True-True] 34.8550μs 25.6793μs 38.9419 KOps/s 38.5265 KOps/s $\color{#35bf28}+1.08\%$
test_step_mdp_speed[False-True-False-True-False] 51.9660μs 16.8729μs 59.2667 KOps/s 58.0879 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[False-True-False-False-True] 48.7300μs 17.0608μs 58.6139 KOps/s 57.6686 KOps/s $\color{#35bf28}+1.64\%$
test_step_mdp_speed[False-True-False-False-False] 56.2350μs 11.3182μs 88.3534 KOps/s 86.9622 KOps/s $\color{#35bf28}+1.60\%$
test_step_mdp_speed[False-False-True-True-True] 73.2960μs 26.7712μs 37.3535 KOps/s 37.4995 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[False-False-True-True-False] 67.6360μs 18.2996μs 54.6460 KOps/s 53.7701 KOps/s $\color{#35bf28}+1.63\%$
test_step_mdp_speed[False-False-True-False-True] 61.2040μs 17.0691μs 58.5855 KOps/s 57.2822 KOps/s $\color{#35bf28}+2.28\%$
test_step_mdp_speed[False-False-True-False-False] 35.7260μs 11.3291μs 88.2685 KOps/s 87.3862 KOps/s $\color{#35bf28}+1.01\%$
test_step_mdp_speed[False-False-False-True-True] 70.8620μs 27.4635μs 36.4120 KOps/s 36.0061 KOps/s $\color{#35bf28}+1.13\%$
test_step_mdp_speed[False-False-False-True-False] 63.7380μs 19.3177μs 51.7661 KOps/s 51.0150 KOps/s $\color{#35bf28}+1.47\%$
test_step_mdp_speed[False-False-False-False-True] 43.3300μs 18.3877μs 54.3842 KOps/s 54.6131 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[False-False-False-False-False] 40.8160μs 12.3994μs 80.6491 KOps/s 79.6330 KOps/s $\color{#35bf28}+1.28\%$
test_values[generalized_advantage_estimate-True-True] 12.3250ms 9.2830ms 107.7234 Ops/s 107.0653 Ops/s $\color{#35bf28}+0.61\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.3737ms 32.8792ms 30.4143 Ops/s 28.6500 Ops/s $\textbf{\color{#35bf28}+6.16\%}$
test_values[td0_return_estimate-False-False] 0.2257ms 0.1629ms 6.1390 KOps/s 6.1320 KOps/s $\color{#35bf28}+0.11\%$
test_values[td1_return_estimate-False-False] 24.4230ms 22.8401ms 43.7826 Ops/s 44.1510 Ops/s $\color{#d91a1a}-0.83\%$
test_values[vec_td1_return_estimate-False-False] 34.0895ms 32.8787ms 30.4148 Ops/s 28.3268 Ops/s $\textbf{\color{#35bf28}+7.37\%}$
test_values[td_lambda_return_estimate-True-False] 34.2956ms 33.0038ms 30.2996 Ops/s 30.3422 Ops/s $\color{#d91a1a}-0.14\%$
test_values[vec_td_lambda_return_estimate-True-False] 33.7834ms 32.9348ms 30.3630 Ops/s 28.5166 Ops/s $\textbf{\color{#35bf28}+6.47\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.2558ms 8.1272ms 123.0437 Ops/s 124.4245 Ops/s $\color{#d91a1a}-1.11\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.4773ms 1.9639ms 509.1893 Ops/s 560.3359 Ops/s $\textbf{\color{#d91a1a}-9.13\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4113ms 0.3428ms 2.9171 KOps/s 2.8439 KOps/s $\color{#35bf28}+2.57\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 39.9514ms 39.2646ms 25.4682 Ops/s 25.0233 Ops/s $\color{#35bf28}+1.78\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.8744ms 3.0101ms 332.2125 Ops/s 331.4211 Ops/s $\color{#35bf28}+0.24\%$
test_dqn_speed 70.8062ms 1.4283ms 700.1446 Ops/s 739.0477 Ops/s $\textbf{\color{#d91a1a}-5.26\%}$
test_ddpg_speed 3.8322ms 2.7666ms 361.4544 Ops/s 369.7055 Ops/s $\color{#d91a1a}-2.23\%$
test_sac_speed 9.3454ms 8.2889ms 120.6429 Ops/s 117.7493 Ops/s $\color{#35bf28}+2.46\%$
test_redq_speed 14.3663ms 13.0446ms 76.6602 Ops/s 75.4625 Ops/s $\color{#35bf28}+1.59\%$
test_redq_deprec_speed 14.1618ms 13.1903ms 75.8133 Ops/s 74.8903 Ops/s $\color{#35bf28}+1.23\%$
test_td3_speed 8.9272ms 8.3970ms 119.0896 Ops/s 116.2244 Ops/s $\color{#35bf28}+2.47\%$
test_cql_speed 36.9290ms 36.1740ms 27.6442 Ops/s 27.2916 Ops/s $\color{#35bf28}+1.29\%$
test_a2c_speed 7.7932ms 7.2025ms 138.8411 Ops/s 137.7206 Ops/s $\color{#35bf28}+0.81\%$
test_ppo_speed 9.0081ms 7.5348ms 132.7183 Ops/s 132.4839 Ops/s $\color{#35bf28}+0.18\%$
test_reinforce_speed 7.0235ms 6.4708ms 154.5403 Ops/s 153.3119 Ops/s $\color{#35bf28}+0.80\%$
test_iql_speed 34.2417ms 32.7063ms 30.5752 Ops/s 30.4870 Ops/s $\color{#35bf28}+0.29\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.3755ms 2.5960ms 385.2050 Ops/s 385.1201 Ops/s $\color{#35bf28}+0.02\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8514ms 0.5093ms 1.9634 KOps/s 1.9636 KOps/s $-0.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7167ms 0.4823ms 2.0734 KOps/s 2.0872 KOps/s $\color{#d91a1a}-0.66\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9801ms 2.6106ms 383.0474 Ops/s 386.9758 Ops/s $\color{#d91a1a}-1.02\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8761ms 0.5041ms 1.9837 KOps/s 1.9813 KOps/s $\color{#35bf28}+0.12\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6703ms 0.4765ms 2.0987 KOps/s 2.0896 KOps/s $\color{#35bf28}+0.43\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8658ms 2.7003ms 370.3242 Ops/s 370.7519 Ops/s $\color{#d91a1a}-0.12\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9947ms 0.6284ms 1.5912 KOps/s 1.5941 KOps/s $\color{#d91a1a}-0.18\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9105ms 0.5981ms 1.6719 KOps/s 1.6772 KOps/s $\color{#d91a1a}-0.31\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.7899ms 2.5765ms 388.1218 Ops/s 390.1272 Ops/s $\color{#d91a1a}-0.51\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6065ms 0.5074ms 1.9710 KOps/s 1.9771 KOps/s $\color{#d91a1a}-0.31\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7923ms 0.4829ms 2.0708 KOps/s 2.0462 KOps/s $\color{#35bf28}+1.20\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1254ms 2.7868ms 358.8380 Ops/s 388.0928 Ops/s $\textbf{\color{#d91a1a}-7.54\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6236ms 0.5054ms 1.9786 KOps/s 1.9842 KOps/s $\color{#d91a1a}-0.28\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6243ms 0.4767ms 2.0979 KOps/s 2.0312 KOps/s $\color{#35bf28}+3.29\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.8216ms 2.8649ms 349.0490 Ops/s 368.8580 Ops/s $\textbf{\color{#d91a1a}-5.37\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0058ms 0.6323ms 1.5816 KOps/s 1.6028 KOps/s $\color{#d91a1a}-1.32\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7645ms 0.5995ms 1.6681 KOps/s 1.6624 KOps/s $\color{#35bf28}+0.34\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1139s 8.2034ms 121.8999 Ops/s 134.3120 Ops/s $\textbf{\color{#d91a1a}-9.24\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 20.2231ms 13.6506ms 73.2571 Ops/s 76.1197 Ops/s $\color{#d91a1a}-3.76\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 3.9654ms 2.5108ms 398.2812 Ops/s 395.8736 Ops/s $\color{#35bf28}+0.61\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1036s 9.7903ms 102.1416 Ops/s 107.8795 Ops/s $\textbf{\color{#d91a1a}-5.32\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 19.7528ms 13.5097ms 74.0207 Ops/s 76.4009 Ops/s $\color{#d91a1a}-3.12\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 4.2771ms 2.5331ms 394.7769 Ops/s 395.0839 Ops/s $\color{#d91a1a}-0.08\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1052s 8.2291ms 121.5193 Ops/s 103.8729 Ops/s $\textbf{\color{#35bf28}+16.99\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.5068ms 13.7549ms 72.7012 Ops/s 75.3337 Ops/s $\color{#d91a1a}-3.49\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.6987ms 2.7457ms 364.2046 Ops/s 353.7901 Ops/s $\color{#35bf28}+2.94\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1129s 0.1116s 8.9634 Ops/s 8.8299 Ops/s $\color{#35bf28}+1.51\%$
test_sync 0.1709s 0.1025s 9.7577 Ops/s 9.7546 Ops/s $\color{#35bf28}+0.03\%$
test_async 0.2484s 91.4772ms 10.9317 Ops/s 10.8224 Ops/s $\color{#35bf28}+1.01\%$
test_single_pixels 0.1341s 0.1336s 7.4870 Ops/s 8.0909 Ops/s $\textbf{\color{#d91a1a}-7.46\%}$
test_sync_pixels 77.6028ms 74.4161ms 13.4380 Ops/s 12.6704 Ops/s $\textbf{\color{#35bf28}+6.06\%}$
test_async_pixels 0.1401s 71.8599ms 13.9160 Ops/s 13.8498 Ops/s $\color{#35bf28}+0.48\%$
test_simple 0.8826s 0.8118s 1.2319 Ops/s 1.2360 Ops/s $\color{#d91a1a}-0.34\%$
test_transformed 1.1031s 1.0338s 0.9673 Ops/s 0.9554 Ops/s $\color{#35bf28}+1.24\%$
test_serial 2.3999s 2.3372s 0.4279 Ops/s 0.4198 Ops/s $\color{#35bf28}+1.92\%$
test_parallel 2.1979s 2.1125s 0.4734 Ops/s 0.4778 Ops/s $\color{#d91a1a}-0.94\%$
test_step_mdp_speed[True-True-True-True-True] 0.1022ms 33.3915μs 29.9478 KOps/s 30.7105 KOps/s $\color{#d91a1a}-2.48\%$
test_step_mdp_speed[True-True-True-True-False] 42.2510μs 19.6739μs 50.8288 KOps/s 52.0744 KOps/s $\color{#d91a1a}-2.39\%$
test_step_mdp_speed[True-True-True-False-True] 33.3800μs 18.6305μs 53.6754 KOps/s 54.9877 KOps/s $\color{#d91a1a}-2.39\%$
test_step_mdp_speed[True-True-True-False-False] 29.9900μs 11.0831μs 90.2278 KOps/s 91.3845 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[True-True-False-True-True] 59.6500μs 34.5179μs 28.9705 KOps/s 29.5202 KOps/s $\color{#d91a1a}-1.86\%$
test_step_mdp_speed[True-True-False-True-False] 42.2910μs 21.4251μs 46.6741 KOps/s 47.4303 KOps/s $\color{#d91a1a}-1.59\%$
test_step_mdp_speed[True-True-False-False-True] 37.2510μs 20.4251μs 48.9593 KOps/s 49.5818 KOps/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[True-True-False-False-False] 35.6310μs 12.9767μs 77.0609 KOps/s 78.0565 KOps/s $\color{#d91a1a}-1.28\%$
test_step_mdp_speed[True-False-True-True-True] 56.0610μs 36.8837μs 27.1122 KOps/s 27.7638 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[True-False-True-True-False] 39.6500μs 23.3906μs 42.7523 KOps/s 43.1464 KOps/s $\color{#d91a1a}-0.91\%$
test_step_mdp_speed[True-False-True-False-True] 45.2610μs 20.5294μs 48.7107 KOps/s 49.8579 KOps/s $\color{#d91a1a}-2.30\%$
test_step_mdp_speed[True-False-True-False-False] 27.7000μs 12.9271μs 77.3566 KOps/s 78.3193 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[True-False-False-True-True] 56.9410μs 38.3398μs 26.0826 KOps/s 26.4286 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[True-False-False-True-False] 46.1310μs 25.2235μs 39.6455 KOps/s 40.2795 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[True-False-False-False-True] 45.9810μs 22.2197μs 45.0051 KOps/s 45.9747 KOps/s $\color{#d91a1a}-2.11\%$
test_step_mdp_speed[True-False-False-False-False] 39.2900μs 14.9211μs 67.0192 KOps/s 68.4843 KOps/s $\color{#d91a1a}-2.14\%$
test_step_mdp_speed[False-True-True-True-True] 54.9310μs 36.4106μs 27.4645 KOps/s 27.8784 KOps/s $\color{#d91a1a}-1.48\%$
test_step_mdp_speed[False-True-True-True-False] 43.0700μs 23.3936μs 42.7468 KOps/s 43.3316 KOps/s $\color{#d91a1a}-1.35\%$
test_step_mdp_speed[False-True-True-False-True] 43.1910μs 24.2680μs 41.2066 KOps/s 41.5260 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[False-True-True-False-False] 29.6410μs 14.7944μs 67.5931 KOps/s 67.0814 KOps/s $\color{#35bf28}+0.76\%$
test_step_mdp_speed[False-True-False-True-True] 66.9310μs 38.5799μs 25.9202 KOps/s 26.5063 KOps/s $\color{#d91a1a}-2.21\%$
test_step_mdp_speed[False-True-False-True-False] 50.4410μs 25.4054μs 39.3617 KOps/s 39.0352 KOps/s $\color{#35bf28}+0.84\%$
test_step_mdp_speed[False-True-False-False-True] 45.9710μs 25.9815μs 38.4890 KOps/s 38.8831 KOps/s $\color{#d91a1a}-1.01\%$
test_step_mdp_speed[False-True-False-False-False] 33.8510μs 16.6180μs 60.1759 KOps/s 59.8602 KOps/s $\color{#35bf28}+0.53\%$
test_step_mdp_speed[False-False-True-True-True] 60.6110μs 40.9436μs 24.4238 KOps/s 25.3800 KOps/s $\color{#d91a1a}-3.77\%$
test_step_mdp_speed[False-False-True-True-False] 53.7910μs 27.6817μs 36.1249 KOps/s 37.1433 KOps/s $\color{#d91a1a}-2.74\%$
test_step_mdp_speed[False-False-True-False-True] 58.9710μs 26.4763μs 37.7696 KOps/s 38.1532 KOps/s $\color{#d91a1a}-1.01\%$
test_step_mdp_speed[False-False-True-False-False] 34.5000μs 16.6572μs 60.0339 KOps/s 60.4359 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[False-False-False-True-True] 65.5610μs 42.3621μs 23.6060 KOps/s 24.2136 KOps/s $\color{#d91a1a}-2.51\%$
test_step_mdp_speed[False-False-False-True-False] 52.3210μs 29.2729μs 34.1613 KOps/s 34.8815 KOps/s $\color{#d91a1a}-2.06\%$
test_step_mdp_speed[False-False-False-False-True] 41.4900μs 27.8246μs 35.9394 KOps/s 36.4247 KOps/s $\color{#d91a1a}-1.33\%$
test_step_mdp_speed[False-False-False-False-False] 35.0510μs 18.2447μs 54.8105 KOps/s 54.1693 KOps/s $\color{#35bf28}+1.18\%$
test_values[generalized_advantage_estimate-True-True] 24.2670ms 23.7693ms 42.0711 Ops/s 39.7797 Ops/s $\textbf{\color{#35bf28}+5.76\%}$
test_values[vec_generalized_advantage_estimate-True-True] 85.1981ms 3.2539ms 307.3282 Ops/s 291.2734 Ops/s $\textbf{\color{#35bf28}+5.51\%}$
test_values[td0_return_estimate-False-False] 0.1027ms 59.6498μs 16.7645 KOps/s 16.5120 KOps/s $\color{#35bf28}+1.53\%$
test_values[td1_return_estimate-False-False] 52.0793ms 51.1990ms 19.5316 Ops/s 18.6886 Ops/s $\color{#35bf28}+4.51\%$
test_values[vec_td1_return_estimate-False-False] 2.0310ms 1.7427ms 573.8149 Ops/s 560.3460 Ops/s $\color{#35bf28}+2.40\%$
test_values[td_lambda_return_estimate-True-False] 83.2445ms 82.0049ms 12.1944 Ops/s 11.5486 Ops/s $\textbf{\color{#35bf28}+5.59\%}$
test_values[vec_td_lambda_return_estimate-True-False] 8.0190ms 1.8723ms 534.1072 Ops/s 548.7376 Ops/s $\color{#d91a1a}-2.67\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 22.9658ms 22.3018ms 44.8394 Ops/s 42.1176 Ops/s $\textbf{\color{#35bf28}+6.46\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8495ms 0.6766ms 1.4780 KOps/s 1.4246 KOps/s $\color{#35bf28}+3.75\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7214ms 0.6331ms 1.5795 KOps/s 1.5096 KOps/s $\color{#35bf28}+4.63\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5074ms 1.4328ms 697.9264 Ops/s 694.4039 Ops/s $\color{#35bf28}+0.51\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9158ms 0.6529ms 1.5315 KOps/s 1.5140 KOps/s $\color{#35bf28}+1.16\%$
test_dqn_speed 1.8398ms 1.3961ms 716.2880 Ops/s 705.5713 Ops/s $\color{#35bf28}+1.52\%$
test_ddpg_speed 3.0352ms 2.6778ms 373.4408 Ops/s 375.4178 Ops/s $\color{#d91a1a}-0.53\%$
test_sac_speed 8.7453ms 8.2609ms 121.0515 Ops/s 120.9546 Ops/s $\color{#35bf28}+0.08\%$
test_redq_speed 11.2783ms 10.4471ms 95.7202 Ops/s 97.9892 Ops/s $\color{#d91a1a}-2.32\%$
test_redq_deprec_speed 11.7227ms 11.1973ms 89.3076 Ops/s 86.3261 Ops/s $\color{#35bf28}+3.45\%$
test_td3_speed 8.7045ms 8.4308ms 118.6124 Ops/s 115.9748 Ops/s $\color{#35bf28}+2.27\%$
test_cql_speed 27.2773ms 25.9510ms 38.5341 Ops/s 39.2797 Ops/s $\color{#d91a1a}-1.90\%$
test_a2c_speed 5.7887ms 5.4452ms 183.6488 Ops/s 195.0043 Ops/s $\textbf{\color{#d91a1a}-5.82\%}$
test_ppo_speed 6.8645ms 5.7748ms 173.1660 Ops/s 182.2048 Ops/s $\color{#d91a1a}-4.96\%$
test_reinforce_speed 4.9823ms 4.5026ms 222.0959 Ops/s 238.6293 Ops/s $\textbf{\color{#d91a1a}-6.93\%}$
test_iql_speed 0.1151s 21.7972ms 45.8775 Ops/s 51.5520 Ops/s $\textbf{\color{#d91a1a}-11.01\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7536ms 3.5410ms 282.4064 Ops/s 281.4463 Ops/s $\color{#35bf28}+0.34\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7352ms 0.5639ms 1.7733 KOps/s 1.7560 KOps/s $\color{#35bf28}+0.98\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6865ms 0.5387ms 1.8563 KOps/s 1.8518 KOps/s $\color{#35bf28}+0.24\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.8503ms 3.5854ms 278.9072 Ops/s 275.3940 Ops/s $\color{#35bf28}+1.28\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7435ms 0.5568ms 1.7958 KOps/s 1.7736 KOps/s $\color{#35bf28}+1.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6809ms 0.5308ms 1.8840 KOps/s 1.8596 KOps/s $\color{#35bf28}+1.31\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.0270ms 3.6841ms 271.4336 Ops/s 268.9256 Ops/s $\color{#35bf28}+0.93\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8171ms 0.6853ms 1.4593 KOps/s 1.4343 KOps/s $\color{#35bf28}+1.74\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8008ms 0.6625ms 1.5094 KOps/s 1.4927 KOps/s $\color{#35bf28}+1.12\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.6828ms 3.5267ms 283.5543 Ops/s 279.6822 Ops/s $\color{#35bf28}+1.38\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7487ms 0.5656ms 1.7682 KOps/s 1.7550 KOps/s $\color{#35bf28}+0.75\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7652ms 0.5401ms 1.8515 KOps/s 1.8367 KOps/s $\color{#35bf28}+0.81\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.7966ms 3.5560ms 281.2150 Ops/s 275.0774 Ops/s $\color{#35bf28}+2.23\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8150ms 0.5609ms 1.7830 KOps/s 1.7734 KOps/s $\color{#35bf28}+0.54\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6710ms 0.5325ms 1.8781 KOps/s 1.8548 KOps/s $\color{#35bf28}+1.25\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.8513ms 3.7038ms 269.9963 Ops/s 268.6883 Ops/s $\color{#35bf28}+0.49\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8773ms 0.6857ms 1.4583 KOps/s 1.4250 KOps/s $\color{#35bf28}+2.34\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8501ms 0.6677ms 1.4976 KOps/s 1.4912 KOps/s $\color{#35bf28}+0.43\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1215s 10.1028ms 98.9822 Ops/s 97.9156 Ops/s $\color{#35bf28}+1.09\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.9915ms 15.9310ms 62.7708 Ops/s 60.8028 Ops/s $\color{#35bf28}+3.24\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.5672ms 3.0350ms 329.4922 Ops/s 325.1357 Ops/s $\color{#35bf28}+1.34\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1201s 10.0890ms 99.1180 Ops/s 99.9184 Ops/s $\color{#d91a1a}-0.80\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.4773ms 15.9473ms 62.7064 Ops/s 60.4592 Ops/s $\color{#35bf28}+3.72\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 8.3149ms 3.0496ms 327.9155 Ops/s 317.5053 Ops/s $\color{#35bf28}+3.28\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1214s 10.4602ms 95.6001 Ops/s 97.1449 Ops/s $\color{#d91a1a}-1.59\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.4607ms 16.1923ms 61.7579 Ops/s 51.9206 Ops/s $\textbf{\color{#35bf28}+18.95\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.4509ms 3.2966ms 303.3389 Ops/s 298.4869 Ops/s $\color{#35bf28}+1.63\%$

vmoens
vmoens approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!

@vmoens vmoens merged commit 31bea14 into main Feb 16, 2024
@vmoens vmoens deleted the sdym/onw branch February 27, 2024 00:47
vmoens pushed a commit that referenced this pull request Feb 28, 2024
@kit1980 @vmoens
Fix onw typo (#1917)
2bfbc51
@vmoens vmoens mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kit1980 @vmoens @facebook-github-bot
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载