+
Skip to content

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Mar 10, 2025

This PR promotes low bit optimizers out of prototype, in particular it updates the folder, tests and benchmarks, renamed low_bit_optim to just optim

I also kept a tiny shim in prototype to the new imports so this doesn't break BC

Copy link

pytorch-bot bot commented Mar 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1864

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit e754d89 with merge base 073b4f0 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2025
@msaroufim msaroufim changed the title Promote Low Bit Optim out of prototype [WIP] Promote Low Bit Optim out of prototype Mar 10, 2025
@msaroufim msaroufim marked this pull request as draft March 10, 2025 19:06
@msaroufim msaroufim added the topic: new feature Use this tag if this PR adds a new feature label Mar 10, 2025
@msaroufim msaroufim changed the title [WIP] Promote Low Bit Optim out of prototype Promote Low Bit Optim out of prototype Mar 10, 2025
@msaroufim msaroufim marked this pull request as ready for review March 10, 2025 21:44
@msaroufim msaroufim merged commit ed6ec9c into main Mar 10, 2025
17 of 18 checks passed
@msaroufim msaroufim mentioned this pull request Mar 10, 2025
11 tasks
@msaroufim msaroufim deleted the msaroufim/promote_opt branch March 11, 2025 03:49
@gau-nernst gau-nernst mentioned this pull request Mar 12, 2025
2 tasks
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
* Remove prototype profiler

* Promote low bit optim out of prototype

* change name

* update

* move test file

* push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: new feature Use this tag if this PR adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载