-
Notifications
You must be signed in to change notification settings - Fork 15
standard CI envs dir & naming conventions #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=======================================
+ Coverage 95.0% 96.2% +1.2%
=======================================
Files 6 7 +1
Lines 480 473 -7
Branches 109 0 -109
=======================================
- Hits 456 455 -1
- Misses 14 18 +4
+ Partials 10 0 -10 🚀 New features to boost your workflow:
|
py311_access-oldest, | ||
py311_access-latest, | ||
py312_access-latest, | ||
py313_access-latest, | ||
py313_access-dev, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this was discussed during the dev call? Imho it is redundant given it lives in access
repo but have no strong feelings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is also by design so it is easier to keep track of exactly which has failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What? I don't see the suffixes here, how is that by design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are talking about 2 different things. I talking simply about the file name of the testing environments.
Do you mean that the label is longer so it is truncated? Maybe that's simply a browser issue because this is how I see:
Wrong screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concede your point @martinfleis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are looking at the result through the Actions tab but this is how it looks like from within the PR. Irrespective of the cause, this change is now making the interaction more complicated while providing little to no value. I am not maintaining access or spopt but if this is supposed to be new default across the federation, I'd like to have a further discussion about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also make copy&paste between subprojects more work as you need to replace the names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are looking at the result through the Actions tab but this is how it looks like from within the PR. Irrespective of the cause, this change is now making the interaction more complicated while providing little to no value.
I already conceded your point there. I had not realized previously that the truncation was happening everywhere on GH. That was my mistake.
It also make copy&paste between subprojects more work as you need to replace the names.
This was my intention – making things explicit to avoid copy&paste mistakes.
I'd like to have a further discussion about it.
I am absolutely on board with more discussion and ideas better than mine. Let's not merge this PR. I'll look back into ones I previously did for spopt
etc. as time permits. And also pause on implementing these updates in other packages for now.
@martinfleis can you give an explicit approval here (if you do so approve)? |
ci/
vs..ci/
submodule_template#45 (comment)