+
Skip to content

move requires out of global lib #344

@mroth

Description

@mroth

Currently, in lib/lolcommits.rb, we require all external gems and libraries at the root level of the library:

require 'mini_magick'
require 'core_ext/mini_magick/utilities'
require 'fileutils'
require 'git'
require 'open3'
require 'methadone'
require 'date'
require 'mercurial-ruby'
require 'core_ext/mercurial-ruby/shell'

We should refactor to have only the files that actually use these gem deps require them, this is best practice for a project of this size, and will aide in future refactors because we can understand where our deps actually come from.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载