Tags: levibostian/decaf
Tags
build: compile binary with deno 2.2 because potential bug found in 2.3 The CI server upgraded to v2.3.1 today over 2.2. The compiled binary hit a runtime exception and so as a fix, I am locking to 2.2 and reporting the bug. Error I got: error: Uncaught (in promise) NotCapable: Requires env access to "NODE_V8_COVERAGE", specify the required permissions during compilation using `deno compile --allow-env` if (global.FinalizationRegistry && !process.env.NODE_V8_COVERAGE) { ^ at Object.getEnv [as get] (ext:deno_os/30_os.js:124:10) at denoEnvGet (ext:deno_node/_process/process.ts:27:21) at Object.get (ext:deno_node/_process/process.ts:44:22) at Object.<anonymous> (file:///tmp/deno-compile-deployer/.deno_compile_node_modules/localhost/undici/5.28.4/lib/core/connect.js:18:49) at Object.<anonymous> (file:///tmp/deno-compile-deployer/.deno_compile_node_modules/localhost/undici/5.28.4/lib/core/connect.js:191:4) at Module._compile (node:module:745:34) at loadMaybeCjs (node:module:770:10) at Object.Module._extensions..js (node:module:755:12) at Module.load (node:module:662:32) at Module._load (node:module:534:12)
fix: tool creates and updates only 1 comment in PR Expected behavior: tool only ever has 1 comment existing in a PR. It updates the same one over and over. Actual behavior: 2+ comments exist in a PR.
fix: bug where tool says there are zero commits even after simulated … …merge (#47) ## Related GitHub Issues <!-- Link to any related GitHub issues that this pull request addresses or closes. --> ## Problem <!-- A clear description of the problem that this pull request is solving. --> [Bug found in this PR](#46) (not introduced by that PR, just found when the CI ran).  if the parent branch has zero commits (example: merging a PR into main branch and main branch currently has no new commits in it since last release) and you do a simulated merge, we expect that the tool analyzes those simulated merges. Actual behavior with the bug is it exits early. ## Solution <!-- Describe the approach you took to solve the problem and the changes made in this pull request. --> ## Testing <!-- Choose one of the below options for how you tested the code change. Include any specific setup or instructions for testing. --> - [X] Added automated tests. - [ ] Manually tested. If you check this box, provide instructions for others to test, too. ## Notes for reviewers <!-- If there is any additional information you would like to share with the person reviewing this pull request, please provide it here. -->
PreviousNext