library.sh uses outdated gotestsum causing unit test failures with Go 1.25 #437
Description
Description
The report_go_test function in hack/library.sh hardcodes gotestsum@v1.11.0, which depends on golang.org/x/tools@v0.11.0. This version of golang.org/x/tools is incompatible with Go 1.25.0, causing unit tests to fail in downstream repositories eventing and eventing-kafka-broker.
Eventually go.mods will be updated to Go 1.25.0, or? Maybe we can bump the version of tools already? I can submit a PR! @maschmid @cardil
Line 591 in 1499de2
Error from knative/eventing:
./test/presubmit-tests.sh --unit-tests
╔════════════════════════╗
║ ║
║ RUNNING UNIT TESTS ║
║ ║
╚════════════════════════╝
╭─────────────────────────────────────╮
│ Unit tests for knative.dev/eventing │
╰─────────────────────────────────────╯
Running go test with args: -short -race -count 1 ./...
# golang.org/x/tools/internal/tokeninternal
/home/user/go/pkg/mod/golang.org/x/tools@v0.11.0/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64)
Finished run, return code is 1
XML report written to /tmp/knative.MBlY3wuq/tmp.eAayMMcIeC/junit_ymcRpUii.xml
Test log (JSONL) written to /tmp/knative.MBlY3wuq/tmp.eAayMMcIeC/go_test_ymcRpUii.jsonl
panic: open /tmp/knative.MBlY3wuq/tmp.eAayMMcIeC/go_test_ymcRpUii.jsonl: no such file or directory
goroutine 1 [running]:
main.main()
/home/user/go/pkg/mod/github.com/gotesttools/gotestfmt/v2@v2.5.0/cmd/gotestfmt/main.go:173 +0x517
exit status 2
Test log (ANSI) written to /tmp/knative.MBlY3wuq/tmp.eAayMMcIeC/go_test_ymcRpUii-ansi.log
Test log (HTML) written to /tmp/knative.MBlY3wuq/tmp.eAayMMcIeC/go_test_ymcRpUii.html
Command '__unit_test_runner_for_module' failed in module /home/user/Dev/active/knative/forks/knative-eventing: 1
Step failed: default_unit_test_runner
╔══════════════════════════════╗
║ ║
║ ERROR: Unit tests FAILED ║
║ ║
╚══════════════════════════════╝
Step failed: run_unit_testsError from knative/eventing-kafka-broker:
./hack/run.sh unit-tests-control-plane
Using loom modules true
╭──────────────────────────────────────────────────╮
│ Unit tests for knative.dev/eventing-kafka-broker │
╰──────────────────────────────────────────────────╯
Running go test with args: -short -race -count 1 ./...
# golang.org/x/tools/internal/tokeninternal
/home/user/go/pkg/mod/golang.org/x/tools@v0.11.0/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64)
Finished run, return code is 1
XML report written to /tmp/knative.nk9TG2Fv/tmp.a6tKhNtdwz/junit_E6uArWYE.xml
Test log (JSONL) written to /tmp/knative.nk9TG2Fv/tmp.a6tKhNtdwz/go_test_E6uArWYE.jsonl
panic: open /tmp/knative.nk9TG2Fv/tmp.a6tKhNtdwz/go_test_E6uArWYE.jsonl: no such file or directory
goroutine 1 [running]:
main.main()
/home/user/go/pkg/mod/github.com/gotesttools/gotestfmt/v2@v2.5.0/cmd/gotestfmt/main.go:173 +0x517
exit status 2
Test log (ANSI) written to /tmp/knative.nk9TG2Fv/tmp.a6tKhNtdwz/go_test_E6uArWYE-ansi.log
Test log (HTML) written to /tmp/knative.nk9TG2Fv/tmp.a6tKhNtdwz/go_test_E6uArWYE.html
Command '__unit_test_runner_for_module' failed in module /home/user/Dev/active/knative/forks/knative-eventing-kafka-broker: 1Workaround
I am currently updating the hardcoded package to v1.13.0 to run the unit-tests locally: go_run gotest.tools/gotestsum@v1.13.0