Add auth section for each external service page #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrfox
reviewed
Sep 9, 2024
Comment on lines
+63
to
+76
| auth: | ||
| ca_file: "" | ||
| insecure_skip_verify: false | ||
| password: "pwd" | ||
| token: "" | ||
| type: "basic" | ||
| use_kiali_token: false | ||
| username: "user" |
There was a problem hiding this comment.
Can you also provide an example of using a secret or at least link to it here? The format of this almost always trips people up but it's usually how people want to provide credentials.
There was a problem hiding this comment.
Yes, I think that will be good idea. Maybe adding a FAQ entry and link it from the rest of the pages, so the information is not duplicated
There was a problem hiding this comment.
@nrfox added this https://deploy-preview-814--kiali.netlify.app/docs/faq/authentication/#how-to-configure-a-secret-as-password-for-external-services based in @jmazzitelli instructions (Mazz you might want to have a look?) I've tested it in minikube and works as expected.
Co-authored-by: Nick Fox <nick@nrfox.com>
19a9fbb to
5a0e6e8
Compare
nrfox
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To complete the external services information I've included an auth section for each page: