Remove acrValues from initialization options
#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#72 Signed-off-by: Jon Koops <jonkoops@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated acrValues option from the initialization process, ensuring that acr_values are now only handled via the options passed to createLoginUrl.
- Removed the assignment of acrValues from initOptions in the Keycloak constructor
- Adjusted the URL query parameter generation to only use options.acrValues
Files not reviewed (1)
- docs/guides/securing-apps/javascript-adapter.adoc: Language not supported
|
@thomasdarimont FYI |
rmartinc
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
acrValuesoption during initialization, as it has never worked correctly. This is technically a breaking change, but because the functionality was broken since its first incarnation, we can safely assume that this will have little to no impact.This is part of a larger effort to get rid of options that are duplicated between
init()andcreateLoginUrl()(orlogin()). These duplications only exist for those use cases where callinginit()triggers alogin(), which is a side effect that I want to explicitly get rid of in the future.Closes #72