UserTest for admin-client #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#41 Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
mposolda
reviewed
Sep 17, 2024
client-common-synced/pom.xml
Outdated
| @@ -176,6 +176,7 @@ | |||
| <outputDirectory>${project.build.directory}/unpacked</outputDirectory> | |||
| <includes> | |||
| org/keycloak/utils/StringUtil.java, | |||
| org/keycloak/models/credential/dto/*.java, | |||
There was a problem hiding this comment.
The classes are not needed by admin-client itself and IMO they rather should not be added as part of admin-client exposed to the users of the admin-client.
Is it perhaps possible to fork just the needed classes (PasswordCredentialData and PasswordSecretData) to the testsuite directly? It looks those are the only ones needed right? Hopefully it is fine as those are not changing so often. WDYT?
Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
mposolda
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41
Moved 93 of 115 tests. Tests that require the use of the webdriver and email, such as email verification or password reset tests have been removed. @mposolda