Move AuthzClientCredentialsTest to keycloak-client #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#55 Signed-off-by: rmartinc <rmartinc@redhat.com>
mposolda
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
@rmartinc Approving. Thanks!
Created keycloak/keycloak#32962 as a follow-up (not a blocker for Keycloak 26 IMO, but hopefully we can improve on that.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
Adding the AuthzClientCredentialsTest in the keycloak-client project. This is the test that is problematic because of the CryptoIntegration. Check the issue for details. This draft implements the dummy crypto provider (minimal methods to sign the JWts) in the test-suite. We should decide if we add the implementation in the keycloak project (which make it synched here) or we maintain in the TS part and the user needs to add the crypto implementation if they want to login using JWT tokens.
@mposolda Take a look when you have time. The idea is deciding if we add the dummy crypto implementaion in the keycloak to be used for the authz client or not.