Initial tests for admin-client #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #31869 Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
mposolda
reviewed
Sep 9, 2024
There was a problem hiding this comment.
@graziang Great work, Huge thanks for it!
I have few comments, which are mostly minor things and/or possible follow-up work to this PR. I have only one bigger concern, which is copying the class Keycloak to the testsuite, which I am not sure why it is needed.
testsuite/admin-client-tests/src/test/java/org/keycloak/client/testsuite/RealmTest.java
Outdated
Show resolved
Hide resolved
testsuite/framework/src/main/java/org/keycloak/testsuite/client/Keycloak.java
Outdated
Show resolved
Hide resolved
testsuite/framework/src/main/java/org/keycloak/client/testsuite/framework/KeycloakVersion.java
Outdated
Show resolved
Hide resolved
Closes #31869 Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
|
@mposolda Thanks for the review, I replied to your comments and added another commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR to add admin-client tests from keycloak repository to keycloak-client repository:
Keycloakadmin client class copied into the testsuite to add some useful methods, synced some classes fromkeycloak-server-spiandkeycloak-server-spi-privateinto the admin client such asConstantsandStringUtil. Is this okay, or is it better to copy them into the testsuite?Other classes like
CibaConfig,OAuth2DeviceConfig, andParConfiginstead have been simplified and copied directly into the testsuite due too many dependencies, for example withRealmModel,KeycloakSession, and many others that are currently unnecessary to synchronize.Created
AbstractAdminClientTestwhich imports the default realms and injects theadminClientand theoauthClient.Created the annotation
@KeycloakVersion, which takesminand/ormaxvalues (i.e.@KeycloakVersion(min="25.0.0")) to use on test methods to run the test only on specific Keycloak versions.So far, only the tests
AdminClientTest,RealmTest,RealmRolesTest, andClientTesthave been migrated.Assertions on admin events have been removed.
Tests strictly related to operations that require the use of
KeycloakTestingClientand then related to the testing resource provider (such as run on server) have been removed or modified.Closes keycloak/keycloak#31869