-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Unable to configure TLS reloading in Keycloak version 26.2.0 or later #40790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For additional context, this was due to #32724 - for most mapFrom operations we were using a distinct input value, such that the general transformer did not apply. So the change created a separate mapFrom transformer. It also seemed more complicated to chain the transformations - apply mapFrom first, then the general one, so they were left separate. An alternative to this change is to automatically use the parent transformer when it is present as the mapFrom transformer when it is not specified. |
@mabartos there are two options to prevent the redundency in this situation - it will come up again if we have any other base property with a tranformation.
|
Closes keycloak#40713 Signed-off-by: Martin Bartoš <mabartos@redhat.com> Co-authored-by: Steve Hawkins <shawkins@redhat.com>
@shawkins Thanks. Make sense to me to use the parent mapper if the mapFrom mapper is not specified. It seems to me it's not so invasive change, and we can backport it without risking the mapping will break apart. Btw. we would need to have a diagram on how the transformation works for prop mappers soon 😄 |
Right, it's not always clear how the map from, transformer, and default play together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mabartos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gist of the changes LGTM but relying on @shawkins' deeper review.
…keycloak#40790) Closes keycloak#40713 Signed-off-by: Martin Bartoš <mabartos@redhat.com> Co-authored-by: Steve Hawkins <shawkins@redhat.com>
…keycloak#40790) Closes keycloak#40713 Signed-off-by: Martin Bartoš <mabartos@redhat.com> Co-authored-by: Steve Hawkins <shawkins@redhat.com> (cherry picked from commit 664827d)
…keycloak#40790) Closes keycloak#40713 Signed-off-by: Martin Bartoš <mabartos@redhat.com> Co-authored-by: Steve Hawkins <shawkins@redhat.com> (cherry picked from commit 664827d)
Closes #40713
The
-1
was propagated to thequarkus.management.ssl.certificate.reload-period
property, which was not correct. The reload period for HTTP was not set, which is the correct way. This PR manages both properties behave the same.@shawkins Could you please check it? Thanks!