-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Use updated PostgresDatabase from Liquibase 4.32.0 #40530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.cluster.RealmInvalidationClusterTest#crudWithFailoverKeycloak CI - Store IT (postgres)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good approach!
Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @mabartos for the elaborate analysis of the issue and for providing the fix.
The only concern would be how to test this. We do have migration tests using Postgres, though this issue requires some specific conditions (DB name). Not sure that's something Keycloak should test – it's basically Postgres/Liquibase integration. We can't and shouldn't test all possible corner cases of that, that's probably something Liquibase (or perhaps even Quarkus) should do.
Hence I'm fine with keeping as is, without any specific tests considering this is only a temporary workaround to unblock users.
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
We will discuss what will be the best to fulfill the requirements of the issue, but this might be easily applicable.