+
Skip to content

Use updated PostgresDatabase from Liquibase 4.32.0 #40530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

mabartos
Copy link
Contributor

@mabartos mabartos commented Jun 16, 2025

We will discuss what will be the best to fulfill the requirements of the issue, but this might be easily applicable.

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos mabartos self-assigned this Jun 16, 2025
@mabartos mabartos added the status/hold PR should not be merged. On hold for later. label Jun 16, 2025
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.RealmInvalidationClusterTest#crudWithFailover

Keycloak CI - Store IT (postgres)

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

Copy link
Contributor

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good approach!

@mabartos
Copy link
Contributor Author

mabartos commented Jun 24, 2025

Summary

@vmuzikar @shawkins Could you please check it? Thanks!

@mabartos mabartos marked this pull request as ready for review June 24, 2025 12:54
@mabartos mabartos requested review from a team as code owners June 24, 2025 12:54
@mabartos mabartos requested review from shawkins and vmuzikar June 24, 2025 12:55
Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mabartos for the elaborate analysis of the issue and for providing the fix.

The only concern would be how to test this. We do have migration tests using Postgres, though this issue requires some specific conditions (DB name). Not sure that's something Keycloak should test – it's basically Postgres/Liquibase integration. We can't and shouldn't test all possible corner cases of that, that's probably something Liquibase (or perhaps even Quarkus) should do.

Hence I'm fine with keeping as is, without any specific tests considering this is only a temporary workaround to unblock users.

@vmuzikar vmuzikar merged commit 3a75696 into keycloak:main Jun 24, 2025
80 checks passed
shawkins pushed a commit to shawkins/keycloak that referenced this pull request Jul 1, 2025
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test status/hold PR should not be merged. On hold for later. team/cloud-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liquibase update failed from KC 26.1 to KC 26.2 with PostgreSQL JDBC driver 42.7.5
3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载