+
Skip to content

Conversation

larsgw
Copy link
Contributor

@larsgw larsgw commented Sep 27, 2022

Might need to be more restrictive.

@zkat
Copy link
Member

zkat commented Sep 27, 2022

LGTM, but I'll let others take a look too in case I missed something. I'll also need to update the 2.0 grammar sometime soon after this lands..

@larsgw larsgw marked this pull request as draft September 27, 2022 20:45
@larsgw
Copy link
Contributor Author

larsgw commented Sep 27, 2022

I actually want to change some of the whitespace rules now that I look at it. It's missing whitespace after =>, I think whitespace should be allowed in more places, and I want to allow newlines in all/most whitespace if that's okay with you.

@zkat
Copy link
Member

zkat commented Sep 27, 2022

I'm fine with that

@larsgw
Copy link
Contributor Author

larsgw commented Oct 2, 2022

Should this be a breaking change? Or just make it non-normative until a new major release?

@larsgw
Copy link
Contributor Author

larsgw commented Oct 2, 2022

I tried to split the patch but everything got sent at once so the commit message is a bit misleading, but I:

  • added support for newlines to any whitespace
  • added some places where whitespace is allowed (around most if not all operators)
  • added the two accessors unique to mappings (props(), values())
  • added a notice that this grammar is not normative for now

@larsgw larsgw marked this pull request as ready for review October 2, 2022 20:05
@zkat
Copy link
Member

zkat commented Oct 2, 2022

I think we should just make KQL 2.0.0 and be done with it, instead of trying to incrementally improve 1.0, but that's just me. wdyt?

@larsgw
Copy link
Contributor Author

larsgw commented Oct 2, 2022

That's fine with me too but I think that should be after/together with KDL 2.0.0, not before (given the pending changes to identifiers). I guess KQL 2.0.0 would also include the new selector operators? I'm excited for those.

@zkat zkat added the breaking This can only be done for the next major version of KDL label Oct 2, 2022
@zkat
Copy link
Member

zkat commented Oct 2, 2022

Can you update this PR to target kdl-v2 instead, then? You'll have to rebase, but idk if you'll run into conflicts.

@larsgw larsgw changed the base branch from main to kdl-v2 October 2, 2022 20:42
@larsgw
Copy link
Contributor Author

larsgw commented Oct 2, 2022

Nevermind, that didn't really work I think. I'll rebase locally and force-push.

@larsgw
Copy link
Contributor Author

larsgw commented Oct 2, 2022

Then I've removed the part of the grammar concerning the map operator too, since that was removed.

@zkat zkat merged commit 06d1d67 into kdl-v2 Oct 9, 2022
@zkat zkat deleted the larsgw-patch-3 branch October 9, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This can only be done for the next major version of KDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载