Fix #395: Move from parents() to ancestors() in goutte #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will effectively drop support for symfony/dom-crawler:v4.4 and is thus a breaking change. Sadly the folks of symfony didn't merge the ancestors() function back to the symfony 4.4 libraries but since this change unlocks the upgrade path to laravel 9 and symfony 6 I would say this is acceptable
|
@rjd22 Thanks for your effort and the PR! This looks good, I'll push a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will effectively drop support for
symfony/dom-crawler:v4.4andis thus a breaking change. Sadly the folks of symfony didn't merge
the
ancestors()function back to the symfony 4.4 libraries but sincethis change unlocks the upgrade path to laravel 9 and symfony 6 I
would say this is acceptable