fix: add trailing registry URL slash #3398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewblas
commented
May 28, 2025
| } | ||
| if !strings.HasSuffix(serviceURL.Path, "/") { | ||
| serviceURL.Path += "/" | ||
| } |
There was a problem hiding this comment.
I thought about this second one a lot, not totally sure it's necessary, I think the resolver below was actually already account for mashing two paths together correctly. But included this anyway for consistency
aliscott
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically, the https://registry.terraform.io/.well-known/terraform.json returns
{"modules.v1":"/v1/modules/","providers.v1":"/v1/providers/"}If instead, a custom registry returns no trailing slash, like `{"modules.v1":"/v1/modules","providers.v1":"/v1/providers"}
Then we'd fetch URLs mashing together the path with the module name. This fixes that, akin to hashicorp/terraform@34b4000