fix: terraform env matching on colon separated filenames #3170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue where a terraform var file that started with an env name but was preceded by a `.` would fail to match an env, e.g `dev.foo.tfvars`. This was because of a typo in the prefix matching logic. Changing this logic also exposed an issue when matching hidden file var files (those starting with a `.`). As the previous typo was allowing for them to be successfully matched. Now that I've fixed the prefix matching logic, i've also changed the `clean` logic to remove `.` from the filenames so that the hidden files -> env name matching works as expected.
aliscott
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue where a terraform var file that started with an env name but was preceded by a
.would fail to match an env, e.gdev.foo.tfvars. This was because of a typo in the prefix matching logic see here. Changing this logic also exposed an issue when matching hidden file var files (those starting with a.). As the previous typo was allowing for them to be successfully matched. Now that I've fixed the prefix matching logic, i've also changed thecleanlogic to remove.from the filenames so that the hidden files -> env name matching works as expected.