Fix errored project names to show suffix #3140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly have an error It seems like this test didn't have any error in the Terraform before, so wasn't checking for what it said it was. I've also updated the `TestBreakdownMultiProjectWithError` test to be consistent This test wasn't
Errored projects weren't showing the `-<env>` suffix on their project names in the JSON. This causes `found duplicate project name` issues when running `infracost diff`. This fixes it by making sure that the module always has the suffix, so that if it errors and returns early we still know the suffix. Previously this was only added if the module was parsed successfully.
662106a to
dd03681
Compare
tim775
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errored projects weren't showing the
-<env>suffix on their project names in the JSON. This causesfound duplicate project nameissues when runninginfracost diff.This fixes it by making sure that the module always has the suffix, so that if it errors and returns early we still know the suffix. Previously this was only added if the module was parsed successfully.