+
Skip to content

fix Get the relative path based on the starting path for var files #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix Get the relative path based on the starting path for var files #3105

merged 1 commit into from
Jun 10, 2024

Conversation

owenrumney
Copy link
Contributor

@owenrumney owenrumney commented Jun 10, 2024 •
edited
Loading

Pattern matching doesn't work for the tfvar dependency paths when they're relative but works okay when they're relative to the starting path like module calls

@owenrumney owenrumney requested a review from hugorut June 10, 2024 15:06
hugorut
hugorut approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember in future todo conventional style commits e.g. fix: Get the relative path based on the starting path for var files

@owenrumney owenrumney changed the title Get the relative path based on the starting path for var files fix Get the relative path based on the starting path for var files Jun 10, 2024
fix: Get the relative path based on the starting path for var files
26f5751 
Pattern matching doesn't work for the tfvar dependency paths when
they're relative but works okay when they're relative to the starting
path like module calls
@owenrumney owenrumney force-pushed the fix/relative_dependency_paths branch from 9e0d54e to 26f5751 Compare June 10, 2024 15:13
@owenrumney owenrumney merged commit c70be28 into master Jun 10, 2024
@owenrumney owenrumney deleted the fix/relative_dependency_paths branch June 10, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugorut hugorut hugorut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenrumney @hugorut
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载