+
Skip to content
This repository was archived by the owner on Jul 3, 2025. It is now read-only.

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Aug 3, 2023

just a copy of nodetime from the ignite CLI, for we can start move the binaries

@Pantani Pantani self-assigned this Aug 3, 2023
Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

I believe we should not add any source code to this repo and only use it to keep binary files as we discussed.

Let's talk about how to setup CI to automate this in our next call.

@Pantani Pantani force-pushed the feat/add-nodetime branch from 4f2992a to 6e61ec4 Compare August 7, 2023 13:54
@Pantani Pantani requested a review from ilgooz August 7, 2023 16:20
@Pantani Pantani requested a review from jeronimoalbi August 28, 2023 10:57
@jeronimoalbi
Copy link
Member

I think we need to merge and then also move the code from ignite/cli#3626. Or the PR should be made into this repo instead.

Pantani and others added 2 commits August 30, 2023 09:42
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
Pantani added 2 commits September 1, 2023 14:48
@Pantani Pantani requested a review from jeronimoalbi September 1, 2023 12:51
@jeronimoalbi jeronimoalbi mentioned this pull request Sep 5, 2023
@jeronimoalbi
Copy link
Member

jeronimoalbi commented Sep 7, 2023

@Pantani can we merge this one?

@Pantani
Copy link
Collaborator Author

Pantani commented Sep 7, 2023

@Pantani can we merge this one?

yes, sure!! conflicts solved, I don't have rights to merge

@jeronimoalbi
Copy link
Member

@Pantani can we merge this one?

yes, sure!! conflicts solved, I don't have rights to merge

@ilgooz would you merge this one?

@Pantani Pantani merged commit ef6c24a into main Sep 11, 2023
@Pantani Pantani deleted the feat/add-nodetime branch September 11, 2023 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载