This repository was archived by the owner on Jul 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add nodetime #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
suggested changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
I believe we should not add any source code to this repo and only use it to keep binary files as we discussed.
Let's talk about how to setup CI to automate this in our next call.
4f2992a
to
6e61ec4
Compare
I think we need to merge and then also move the code from ignite/cli#3626. Or the PR should be made into this repo instead. |
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
# Conflicts: # .github/workflows/stats.yaml # Makefile # changelog.md
jeronimoalbi
approved these changes
Sep 1, 2023
jeronimoalbi
reviewed
Sep 4, 2023
jeronimoalbi
approved these changes
Sep 4, 2023
Merged
@Pantani can we merge this one? |
# Conflicts: # go.sum # go.work
yes, sure!! conflicts solved, I don't have rights to merge |
jeronimoalbi
approved these changes
Sep 7, 2023
ilgooz
approved these changes
Sep 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a copy of nodetime from the ignite CLI, for we can start move the binaries