+
Skip to content

chore: use new api (backport #4816) #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2025
Merged

chore: use new api (backport #4816) #4818

merged 2 commits into from
Oct 9, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 9, 2025

previous ones are supported for backward compat, but would be good to update them still for latest ignite versions.

annoucement url is already using the correct url:

cli/ignite/internal/announcements/announcement.go

Line 15 in 58e0dfe

AnnouncementURL = "https://api.ignite.com/v1/announcements"

This is an automatic backport of pull request #4816 done by Mergify.

@julienrbrt @mergify
chore: use new api (#4816)
006cffb 
* chore: use new api

* improvements

* cl

* updates

(cherry picked from commit 99735e0)

# Conflicts:
#	ignite/internal/announcements/announcement_test.go
@mergify mergify bot requested a review from ilgooz as a code owner October 9, 2025 08:44
@mergify mergify bot added the conflicts label Oct 9, 2025
@mergify mergify bot added the conflicts label Oct 9, 2025
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Oct 9, 2025

Cherry-pick of 99735e0 has failed:

On branch mergify/bp/release/v28.x.y/pr-4816
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 99735e0c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/cmd/bubblemodel/chain_serve.go
	modified:   ignite/cmd/cmd.go
	modified:   ignite/internal/analytics/analytics.go
	modified:   ignite/internal/announcements/announcement.go
	modified:   ignite/internal/buf/buf.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/internal/announcements/announcement_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@julienrbrt julienrbrt merged commit 145d2b3 into release/v28.x.y Oct 9, 2025
38 of 43 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4816 branch October 9, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

No one assigned

Labels

component:ci CI/CD workflow and automated jobs. component:cmd component:configs type:internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@julienrbrt
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载