support encrypted issuance message #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for encrypted issuance messages in the protocol by introducing structures and utilities to handle encrypted credentials in different JWE serialization formats.
- Adds
EncryptedCredentialIssuanceMessagestruct and related types for handling encrypted credential payloads - Implements support for both JWE JSON and string serialization formats
- Adds comprehensive test coverage for encrypted credential issuance message parsing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| protocol/credentials_encrypted.go | New file implementing encrypted credential structures, interfaces, and custom unmarshaling logic |
| protocol/credentials_encrypted_test.go | New test file with comprehensive test cases for both JWE serialization formats |
| protocol/credentials.go | Adds new message type constant for encrypted credential issuance response |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vmidyllic
previously approved these changes
Oct 9, 2025
vmidyllic
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.