Fix undefined vars #9
Conversation
|
@ralflang, please merge. |
|
@TDannhauer, please could you review/merge? |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes undefined variable issues in the vacation functionality by correcting variable references and assignments.
- Replaces undefined
$startand$endvariables with empty arrays in Form/Vacation.php - Corrects variable name from
$notificationto$notifyin Basic/Vacation.php
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/Form/Vacation.php | Fixes undefined variable usage by passing empty arrays instead of undefined variables |
| lib/Basic/Vacation.php | Corrects variable assignment to use the properly defined $notify variable |
| $start = $this->_start->getInfo($vars, []); | ||
| $end = $this->_end->getInfo($vars, []); |
There was a problem hiding this comment.
Passing an empty array as the second parameter may not provide the expected default behavior. Consider investigating what the original intent was for the second parameter - it might need a specific default value rather than an empty array.
| $start = $this->_start->getInfo($vars, []); | |
| $end = $this->_end->getInfo($vars, []); | |
| $start = $this->_start->getInfo($vars, $this->_errors); | |
| $end = $this->_end->getInfo($vars, $this->_errors); |
Copilot uses AI. Check for mistakes.
| $start = $this->_start->getInfo($vars, []); | ||
| $end = $this->_end->getInfo($vars, []); |
There was a problem hiding this comment.
Passing an empty array as the second parameter may not provide the expected default behavior. Consider investigating what the original intent was for the second parameter - it might need a specific default value rather than an empty array.
| $start = $this->_start->getInfo($vars, []); | |
| $end = $this->_end->getInfo($vars, []); | |
| $start = $this->_start->getInfo($vars, null); | |
| $end = $this->_end->getInfo($vars, null); |
Copilot uses AI. Check for mistakes.
No description provided.