+
Skip to content

Fix Uninitialized String offset error in validUtf8() #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Uninitialized String offset error in validUtf8() #4

wants to merge 1 commit into from

Conversation

pravussum
Copy link

No description provided.

@yunosh
Copy link
Member

yunosh commented Jan 12, 2022

When does this happen? Do you have a test case?

@pravussum
Copy link
Author

pravussum commented Jan 12, 2022 •
edited
Loading

I made this change in reaction to a crash in Nextcloud Mail (using the Horde libraries under the hood) where the stack trace revealed this very line. I think its an edge case (It was a spam mail being processed).
After fixing it in-place, the crash didn't happen anymore, but I'm afraid I deleted the spam message.

@pravussum
Copy link
Author

I have a backtrace now:

"file":"/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Util/Horde/String.php","line":873,"function":"onAll","class":"OC\\Log\\ErrorHandler","type":"::","args":[2,"Uninitialized string offset 14","/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Util/Horde/String.php",873]
"file":"/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Mime/Horde/Mime/Headers/Element.php","line":126,"function":"validUtf8","class":"Horde_String","type":"::","args":[null]
"file":"/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Mime/Horde/Mime/Headers/Addresses.php","line":86,"function":"_sanityCheck","class":"Horde_Mime_Headers_Element","type":"->","args":[null]
"file":"/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Mime/Horde/Mime/Headers/Element.php","line":79,"function":"_setValue","class":"Horde_Mime_Headers_Addresses","type":"->","args":[null]
"file":"/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Mime/Horde/Mime/Headers/Element.php","line":56,"function":"setValue","class":"Horde_Mime_Headers_Element","type":"->","args":[null]
"file":"/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Mime/Horde/Mime/Headers.php","line":201,"function":"__construct","class":"Horde_Mime_Headers_Element","type":"->","args":["Cc",null]
"file":"/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Mime/Horde/Mime/Headers.php","line":371,"function":"addHeader","class":"Horde_Mime_Headers","type":"->","args":["Cc",null]
"file":"/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Imap_Client/Horde/Imap/Client/Data/Fetch.php","line":628,"function":"parseHeaders","class":"Horde_Mime_Headers","type":"::","args":[{"__class__":"Horde_Stream_Temp","stream":null}]
"file":"/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Imap_Client/Horde/Imap/Client/Data/Fetch.php","line":157,"function":"_getHeaders","class":"Horde_Imap_Client_Data_Fetch","type":"->","args":["0",1,3]

ChristophWurst added a commit to ChristophWurst/Horde_Util that referenced this pull request May 25, 2022
@ChristophWurst
Add \ReturnTypeWillChange for PHP8.1 compatibility (horde#4)
7f8e83b 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pravussum @yunosh
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载