+
Skip to content

Additional fixes in Type.php #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

Conversation

amulet1
Copy link
Collaborator

@amulet1 amulet1 commented Jun 22, 2025

I could not commit directly (no access for some reason).

There are many more places that depend on Horde_Form_Type which have to be modified. Only to be modified yet again for V3.

But to actually make use of the returned error messages all dependents have to start usinggetMessage().

To simplify the code I propose to add (and use) a method like this to Horde_Form_Type class:

public function returnError($message) {
    $this->message = $message;
    return false;
}

Any objections?

@amulet1 amulet1 changed the title fix: Add more missing message assignments Additional fixes in Type.php Jun 23, 2025
@ralflang ralflang merged commit 597b2ca into horde:FRAMEWORK_6_0 Jun 23, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载