+
Skip to content

Conversation

loganrosen
Copy link
Contributor

Summary

Fixing all of the AutoboxingStateCreation lint warnings in the app module and updating the lint baseline accordingly, as part of #5221.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 00:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes AutoboxingStateCreation lint warnings in the app module by replacing mutableStateOf with mutableIntStateOf for integer state variables, improving performance by avoiding unnecessary boxing of primitive int values.

  • Updated 4 ViewModels to use mutableIntStateOf instead of mutableStateOf for integer state variables
  • Added imports for mutableIntStateOf in affected files
  • Updated lint baseline files to remove the resolved warnings

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
automotive/lint-baseline.xml Removed 4 resolved AutoboxingStateCreation lint warnings
app/src/main/kotlin/io/homeassistant/companion/android/widgets/assist/AssistShortcutViewModel.kt Changed serverId to use mutableIntStateOf and added import
app/src/main/kotlin/io/homeassistant/companion/android/settings/qs/ManageTilesViewModel.kt Changed selectedServerId and submitButtonLabel to use mutableIntStateOf and added import
app/src/full/kotlin/io/homeassistant/companion/android/matter/MatterCommissioningViewModel.kt Changed serverId to use mutableIntStateOf and added import
app/lint-baseline.xml Removed 4 resolved AutoboxingStateCreation lint warnings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@TimoPtr TimoPtr merged commit 5e428a7 into home-assistant:main Sep 26, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载